Bug 184872 - stderr used without including stdio.h
Summary: stderr used without including stdio.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-22 08:39 PDT by Ting-Wei Lan
Modified: 2018-04-23 08:24 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.42 KB, patch)
2018-04-22 08:42 PDT, Ting-Wei Lan
no flags Details | Formatted Diff | Diff
Patch (1.40 KB, patch)
2018-04-23 07:03 PDT, Ting-Wei Lan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ting-Wei Lan 2018-04-22 08:39:59 PDT
Please see the patch. Missing includes causes build failure on FreeBSD again ...
Comment 1 Ting-Wei Lan 2018-04-22 08:42:20 PDT
Created attachment 338552 [details]
Patch
Comment 2 Yusuke Suzuki 2018-04-22 14:24:07 PDT
Comment on attachment 338552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338552&action=review

r=me with small nits.

> Source/bmalloc/bmalloc/PerProcess.cpp:29
>  

Do not need this blank line.
Comment 3 Ting-Wei Lan 2018-04-23 07:03:47 PDT
Created attachment 338583 [details]
Patch
Comment 4 Yusuke Suzuki 2018-04-23 07:56:55 PDT
Comment on attachment 338583 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2018-04-23 08:23:40 PDT
Comment on attachment 338583 [details]
Patch

Clearing flags on attachment: 338583

Committed r230915: <https://trac.webkit.org/changeset/230915>
Comment 6 WebKit Commit Bot 2018-04-23 08:23:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-04-23 08:24:19 PDT
<rdar://problem/39646493>