RESOLVED FIXED 184871
[Extra zoom mode] 100vw is roughly half of the viewport width in extra zoom mode
https://bugs.webkit.org/show_bug.cgi?id=184871
Summary [Extra zoom mode] 100vw is roughly half of the viewport width in extra zoom mode
Wenson Hsieh
Reported 2018-04-21 23:47:35 PDT
...same goes for 100vh. Viewport units are currently totally broken in extra zoom mode.
Attachments
Patch (9.38 KB, patch)
2018-04-22 03:12 PDT, Wenson Hsieh
aestes: review+
commit-queue: commit-queue-
Rebase on trunk (9.38 KB, patch)
2018-04-23 12:01 PDT, Wenson Hsieh
no flags
Wenson Hsieh
Comment 1 2018-04-21 23:47:58 PDT
Wenson Hsieh
Comment 2 2018-04-22 03:12:44 PDT
Wenson Hsieh
Comment 3 2018-04-23 11:56:45 PDT
Comment on attachment 338550 [details] Patch Thanks for the review!
WebKit Commit Bot
Comment 4 2018-04-23 11:57:37 PDT
Comment on attachment 338550 [details] Patch Rejecting attachment 338550 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 338550, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: k #1 succeeded at 1 with fuzz 3. patching file LayoutTests/TestExpectations Hunk #1 FAILED at 18. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/TestExpectations.rej patching file LayoutTests/fast/css/extrazoom/viewport-units-shrink-to-fit-expected.txt patching file LayoutTests/fast/css/extrazoom/viewport-units-shrink-to-fit.html Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Andy Estes']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/7414365
Wenson Hsieh
Comment 5 2018-04-23 12:01:37 PDT
Created attachment 338597 [details] Rebase on trunk
WebKit Commit Bot
Comment 6 2018-04-23 12:40:32 PDT
Comment on attachment 338597 [details] Rebase on trunk Clearing flags on attachment: 338597 Committed r230916: <https://trac.webkit.org/changeset/230916>
Note You need to log in before you can comment on or make changes to this bug.