Bug 184870 - Use NetworkLoadChecker for all subresource loads except fetch/XHR
Summary: Use NetworkLoadChecker for all subresource loads except fetch/XHR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-21 22:55 PDT by youenn fablet
Modified: 2018-04-25 20:22 PDT (History)
8 users (show)

See Also:


Attachments
Patch (31.60 KB, patch)
2018-04-21 23:02 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.21 MB, application/zip)
2018-04-22 00:06 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews106 for mac-sierra-wk2 (2.75 MB, application/zip)
2018-04-22 00:13 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (14.61 MB, application/zip)
2018-04-22 00:36 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews116 for mac-sierra (2.97 MB, application/zip)
2018-04-22 00:41 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews200 for win-future (12.65 MB, application/zip)
2018-04-22 00:47 PDT, EWS Watchlist
no flags Details
Patch (32.52 KB, patch)
2018-04-22 08:07 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (33.48 KB, patch)
2018-04-22 09:07 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (14.50 MB, application/zip)
2018-04-22 10:43 PDT, EWS Watchlist
no flags Details
Patch (34.79 KB, patch)
2018-04-22 22:18 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.20 MB, application/zip)
2018-04-22 23:54 PDT, EWS Watchlist
no flags Details
Patch (37.36 KB, patch)
2018-04-23 08:46 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (48.22 KB, patch)
2018-04-23 17:32 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (49.71 KB, patch)
2018-04-23 18:43 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
rebasing (45.50 KB, patch)
2018-04-25 13:45 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (53.27 KB, patch)
2018-04-25 14:53 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (59.77 KB, patch)
2018-04-25 15:06 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews204 for win-future (12.58 MB, application/zip)
2018-04-25 19:00 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-04-21 22:55:01 PDT
Use NetworkLoadChecker for all subresource loads except fetch/XHR
Comment 1 youenn fablet 2018-04-21 22:55:24 PDT
<rdar://problem/39370034>
Comment 2 youenn fablet 2018-04-21 23:02:09 PDT
Created attachment 338544 [details]
Patch
Comment 3 EWS Watchlist 2018-04-22 00:06:30 PDT
Comment on attachment 338544 [details]
Patch

Attachment 338544 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7401512

New failing tests:
http/tests/workers/worker-redirect.html
Comment 4 EWS Watchlist 2018-04-22 00:06:31 PDT
Created attachment 338545 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-04-22 00:13:49 PDT
Comment on attachment 338544 [details]
Patch

Attachment 338544 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7401533

New failing tests:
http/tests/workers/worker-redirect.html
http/tests/misc/redirect-to-about-blank.html
Comment 6 EWS Watchlist 2018-04-22 00:13:51 PDT
Created attachment 338546 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-04-22 00:36:35 PDT
Comment on attachment 338544 [details]
Patch

Attachment 338544 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7401555

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html
http/tests/misc/redirect-to-about-blank.html
http/tests/workers/worker-redirect.html
Comment 8 EWS Watchlist 2018-04-22 00:36:37 PDT
Created attachment 338547 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 9 EWS Watchlist 2018-04-22 00:41:22 PDT
Comment on attachment 338544 [details]
Patch

Attachment 338544 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7401553

New failing tests:
http/tests/workers/worker-redirect.html
Comment 10 EWS Watchlist 2018-04-22 00:41:24 PDT
Created attachment 338548 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 11 EWS Watchlist 2018-04-22 00:47:28 PDT
Comment on attachment 338544 [details]
Patch

Attachment 338544 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7401648

New failing tests:
http/tests/workers/worker-redirect.html
Comment 12 EWS Watchlist 2018-04-22 00:47:39 PDT
Created attachment 338549 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 13 youenn fablet 2018-04-22 08:07:39 PDT
Created attachment 338551 [details]
Patch
Comment 14 youenn fablet 2018-04-22 09:07:44 PDT
Created attachment 338553 [details]
Patch
Comment 15 EWS Watchlist 2018-04-22 10:43:33 PDT
Comment on attachment 338553 [details]
Patch

Attachment 338553 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7404694

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html
Comment 16 EWS Watchlist 2018-04-22 10:43:35 PDT
Created attachment 338555 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 17 youenn fablet 2018-04-22 22:18:59 PDT
Created attachment 338566 [details]
Patch
Comment 18 EWS Watchlist 2018-04-22 23:54:34 PDT
Comment on attachment 338566 [details]
Patch

Attachment 338566 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7409078

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html
Comment 19 EWS Watchlist 2018-04-22 23:54:36 PDT
Created attachment 338570 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 20 youenn fablet 2018-04-23 08:46:09 PDT
Created attachment 338587 [details]
Patch
Comment 21 Chris Dumez 2018-04-23 15:44:30 PDT
Comment on attachment 338587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338587&action=review

> Source/WebKit/NetworkProcess/NetworkLoadChecker.h:93
> +    WebCore::ResourceError validateResourceResponse(WebCore::ResourceResponse&, IsRedirection);

Question: Why cannot we rely on ResourceResponse::isRedirection() ?
Comment 22 youenn fablet 2018-04-23 15:52:36 PDT
Comment on attachment 338587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338587&action=review

>> Source/WebKit/NetworkProcess/NetworkLoadChecker.h:93
>> +    WebCore::ResourceError validateResourceResponse(WebCore::ResourceResponse&, IsRedirection);
> 
> Question: Why cannot we rely on ResourceResponse::isRedirection() ?

We cannot as this is set by NetworkLoadChecker and cached-provided responses might have it set to true while it might not make sense for this load.
But we can probably NetworkLoadChecker::m_redirectCount instead and remove IsRedirection.
Comment 23 youenn fablet 2018-04-23 15:57:11 PDT
(In reply to youenn fablet from comment #22)
> Comment on attachment 338587 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338587&action=review
> 
> >> Source/WebKit/NetworkProcess/NetworkLoadChecker.h:93
> >> +    WebCore::ResourceError validateResourceResponse(WebCore::ResourceResponse&, IsRedirection);
> > 
> > Question: Why cannot we rely on ResourceResponse::isRedirection() ?
> 
> We cannot as this is set by NetworkLoadChecker and cached-provided responses
> might have it set to true while it might not make sense for this load.
> But we can probably NetworkLoadChecker::m_redirectCount instead and remove
> IsRedirection.

Reading the code, we actually can use isRedirection since we set it in the same function using m_redirectCount....
Comment 24 youenn fablet 2018-04-23 17:32:34 PDT
Created attachment 338621 [details]
Patch
Comment 25 youenn fablet 2018-04-23 18:43:45 PDT
Created attachment 338628 [details]
Patch
Comment 26 youenn fablet 2018-04-25 13:45:46 PDT
Created attachment 338787 [details]
rebasing
Comment 27 youenn fablet 2018-04-25 14:53:34 PDT
Created attachment 338802 [details]
Patch
Comment 28 youenn fablet 2018-04-25 15:06:25 PDT
Created attachment 338804 [details]
Patch
Comment 29 EWS Watchlist 2018-04-25 18:59:56 PDT
Comment on attachment 338804 [details]
Patch

Attachment 338804 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7462730

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
Comment 30 EWS Watchlist 2018-04-25 19:00:07 PDT
Created attachment 338845 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 31 youenn fablet 2018-04-25 19:54:19 PDT
Comment on attachment 338804 [details]
Patch

win failure is probably unrelated since the changes here are mostly WK2.
Comment 32 WebKit Commit Bot 2018-04-25 20:22:01 PDT
Comment on attachment 338804 [details]
Patch

Clearing flags on attachment: 338804

Committed r231040: <https://trac.webkit.org/changeset/231040>
Comment 33 WebKit Commit Bot 2018-04-25 20:22:03 PDT
All reviewed patches have been landed.  Closing bug.