Bug 184870 – Use NetworkLoadChecker for all subresource loads except fetch/XHR

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[youenn fablet]

Use NetworkLoadChecker for all subresource loads except fetch/XHR

[youenn fablet]

<rdar://problem/39370034>

[youenn fablet]

Created attachment 338544 [details]
Patch

[EWS Watchlist]

Comment on attachment 338544 [details]
Patch

Attachment 338544 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7401512

New failing tests:
http/tests/workers/worker-redirect.html

[EWS Watchlist]

Created attachment 338545 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 338544 [details]
Patch

Attachment 338544 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7401533

New failing tests:
http/tests/workers/worker-redirect.html
http/tests/misc/redirect-to-about-blank.html

[EWS Watchlist]

Created attachment 338546 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 338544 [details]
Patch

Attachment 338544 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7401555

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html
http/tests/misc/redirect-to-about-blank.html
http/tests/workers/worker-redirect.html

[EWS Watchlist]

Created attachment 338547 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[EWS Watchlist]

Comment on attachment 338544 [details]
Patch

Attachment 338544 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7401553

New failing tests:
http/tests/workers/worker-redirect.html

[EWS Watchlist]

Created attachment 338548 [details]
Archive of layout-test-results from ews116 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 338544 [details]
Patch

Attachment 338544 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7401648

New failing tests:
http/tests/workers/worker-redirect.html

[EWS Watchlist]

Created attachment 338549 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[youenn fablet]

Created attachment 338551 [details]
Patch

[youenn fablet]

Created attachment 338553 [details]
Patch

[EWS Watchlist]

Comment on attachment 338553 [details]
Patch

Attachment 338553 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7404694

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html

[EWS Watchlist]

Created attachment 338555 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[youenn fablet]

Created attachment 338566 [details]
Patch

[EWS Watchlist]

Comment on attachment 338566 [details]
Patch

Attachment 338566 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7409078

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html

[EWS Watchlist]

Created attachment 338570 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[youenn fablet]

Created attachment 338587 [details]
Patch

[Chris Dumez]

Comment on attachment 338587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338587&action=review

> Source/WebKit/NetworkProcess/NetworkLoadChecker.h:93
> +    WebCore::ResourceError validateResourceResponse(WebCore::ResourceResponse&, IsRedirection);

Question: Why cannot we rely on ResourceResponse::isRedirection() ?

[youenn fablet]

Comment on attachment 338587 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338587&action=review

>> Source/WebKit/NetworkProcess/NetworkLoadChecker.h:93
>> +    WebCore::ResourceError validateResourceResponse(WebCore::ResourceResponse&, IsRedirection);
> 
> Question: Why cannot we rely on ResourceResponse::isRedirection() ?

We cannot as this is set by NetworkLoadChecker and cached-provided responses might have it set to true while it might not make sense for this load.
But we can probably NetworkLoadChecker::m_redirectCount instead and remove IsRedirection.

[youenn fablet]

(In reply to youenn fablet from comment #22)
> Comment on attachment 338587 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338587&action=review
> 
> >> Source/WebKit/NetworkProcess/NetworkLoadChecker.h:93
> >> +    WebCore::ResourceError validateResourceResponse(WebCore::ResourceResponse&, IsRedirection);
> > 
> > Question: Why cannot we rely on ResourceResponse::isRedirection() ?
> 
> We cannot as this is set by NetworkLoadChecker and cached-provided responses
> might have it set to true while it might not make sense for this load.
> But we can probably NetworkLoadChecker::m_redirectCount instead and remove
> IsRedirection.

Reading the code, we actually can use isRedirection since we set it in the same function using m_redirectCount....

[youenn fablet]

Created attachment 338621 [details]
Patch

[youenn fablet]

Created attachment 338628 [details]
Patch

[youenn fablet]

Created attachment 338787 [details]
rebasing

[youenn fablet]

Created attachment 338802 [details]
Patch

[youenn fablet]

Created attachment 338804 [details]
Patch

[EWS Watchlist]

Comment on attachment 338804 [details]
Patch

Attachment 338804 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7462730

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

[EWS Watchlist]

Created attachment 338845 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[youenn fablet]

Comment on attachment 338804 [details]
Patch

win failure is probably unrelated since the changes here are mostly WK2.

[WebKit Commit Bot]

Comment on attachment 338804 [details]
Patch

Clearing flags on attachment: 338804

Committed r231040: <https://trac.webkit.org/changeset/231040>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.