Bug 184864 - Expose whether you've built with the Apple Internal SDK
Summary: Expose whether you've built with the Apple Internal SDK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-21 13:00 PDT by Dean Jackson
Modified: 2018-04-22 17:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.32 KB, patch)
2018-04-21 13:02 PDT, Dean Jackson 		no flags Details | Formatted Diff | Diff
Patch (2.33 KB, patch)
2018-04-21 13:06 PDT, Dean Jackson 		wenson_hsieh: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2018-04-21 13:00:11 PDT 
Expose whether you've build with the Apple Internal SDK
Comment 1 Dean Jackson 2018-04-21 13:02:01 PDT 
Created attachment 338532 [details]
Patch
Comment 2 Dean Jackson 2018-04-21 13:06:32 PDT 
Created attachment 338534 [details]
Patch
Comment 3 Wenson Hsieh 2018-04-21 13:27:14 PDT 
Comment on attachment 338534 [details]
Patch

I suppose this would be for a test that we want to run (and pass) on OpenSource bots, but may exercise different codepaths if we've built WebKit with an internal SDK? This seems a bit similar to certain iOS layout tests that we skip in OpenSource TestExpectations but mark as Pass in Internal...I wonder if it makes more sense to just skip these tests in OpenSource instead.
Comment 4 Dean Jackson 2018-04-21 13:29:00 PDT 
Committed r230892: <https://trac.webkit.org/changeset/230892>
Comment 5 Radar WebKit Bug Importer 2018-04-21 13:29:18 PDT 
<rdar://problem/39623401>
Comment 6 Alexey Proskuryakov 2018-04-22 17:27:02 PDT 
> I wonder if it makes more sense to just skip these tests in OpenSource instead.

+1