RESOLVED FIXED 184864
Expose whether you've built with the Apple Internal SDK 
https://bugs.webkit.org/show_bug.cgi?id=184864
Summary Expose whether you've built with the Apple Internal SDK
Dean Jackson
Reported 2018-04-21 13:00:11 PDT
Expose whether you've build with the Apple Internal SDK
Attachments
Patch (2.32 KB, patch)
2018-04-21 13:02 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (2.33 KB, patch)
2018-04-21 13:06 PDT, Dean Jackson 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2018-04-21 13:02:01 PDT
Created attachment 338532 [details] Patch
Dean Jackson
Comment 2 2018-04-21 13:06:32 PDT
Created attachment 338534 [details] Patch
Wenson Hsieh
Comment 3 2018-04-21 13:27:14 PDT
Comment on attachment 338534 [details] Patch I suppose this would be for a test that we want to run (and pass) on OpenSource bots, but may exercise different codepaths if we've built WebKit with an internal SDK? This seems a bit similar to certain iOS layout tests that we skip in OpenSource TestExpectations but mark as Pass in Internal...I wonder if it makes more sense to just skip these tests in OpenSource instead.
Dean Jackson
Comment 4 2018-04-21 13:29:00 PDT
Committed r230892: <https://trac.webkit.org/changeset/230892>
Radar WebKit Bug Importer
Comment 5 2018-04-21 13:29:18 PDT
<rdar://problem/39623401>
Alexey Proskuryakov
Comment 6 2018-04-22 17:27:02 PDT
> I wonder if it makes more sense to just skip these tests in OpenSource instead. +1
Note You need to log in before you can comment on or make changes to this bug.