<rdar://problem/38939468>
Created attachment 338530 [details] Patch
Comment on attachment 338530 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338530&action=review Where is the test? > Source/WebCore/ChangeLog:18 > + 8 frames and then a continuously looping animation going through the remaining frames. We use a frames() first serious use of frames()? nice. > Source/WebCore/Modules/modern-media-controls/controls/compact-activity-indicator.css:33 > + /* There are 23 frames in the sprite. */ > + -webkit-mask-size: 2300% 100%; If you want fully amazing CSS here.... --num-frames: 23; -webkit-mask-size: calc(var(--num-frames) * 100%) 100%;
Comment on attachment 338530 [details] Patch Attachment 338530 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/7397920 New failing tests: media/modern-media-controls/compact-media-controls/compact-media-controls-layout.html media/modern-media-controls/compact-media-controls/compact-media-controls-constructor.html
Created attachment 338533 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 338530 [details] Patch Attachment 338530 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/7397903 New failing tests: media/modern-media-controls/compact-media-controls/compact-media-controls-layout.html media/modern-media-controls/compact-media-controls/compact-media-controls-constructor.html
Created attachment 338535 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 338530 [details] Patch Attachment 338530 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7398184 New failing tests: media/modern-media-controls/compact-media-controls/compact-media-controls-layout.html media/modern-media-controls/compact-media-controls/compact-media-controls-constructor.html
Created attachment 338537 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 338530 [details] Patch Attachment 338530 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/7398251 New failing tests: media/modern-media-controls/compact-media-controls/compact-media-controls-layout.html media/modern-media-controls/compact-media-controls/compact-media-controls-constructor.html
Created attachment 338538 [details] Archive of layout-test-results from ews116 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-sierra Platform: Mac OS X 10.12.6
(In reply to Dean Jackson from comment #2) > Comment on attachment 338530 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=338530&action=review > > Where is the test? > > > Source/WebCore/ChangeLog:18 > > + 8 frames and then a continuously looping animation going through the remaining frames. We use a frames() > > first serious use of frames()? nice. In WebKit source? Probably. > > Source/WebCore/Modules/modern-media-controls/controls/compact-activity-indicator.css:33 > > + /* There are 23 frames in the sprite. */ > > + -webkit-mask-size: 2300% 100%; > > If you want fully amazing CSS here.... --num-frames: 23; -webkit-mask-size: > calc(var(--num-frames) * 100%) 100%; Hell yeah. That's going into the patch for landing.
Committed r230895: <https://trac.webkit.org/changeset/230895>