Bug 184853 - Make DocumentThreadableLoader error logging more consistent
Summary: Make DocumentThreadableLoader error logging more consistent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-20 17:15 PDT by youenn fablet
Modified: 2018-04-25 10:59 PDT (History)
10 users (show)

See Also:

Attachments
Patch (3.32 KB, patch)
2018-04-20 17:18 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.21 MB, application/zip)
2018-04-20 20:53 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.83 MB, application/zip)
2018-04-20 22:21 PDT, EWS Watchlist 		no flags Details
Patch (190.23 KB, patch)
2018-04-23 15:04 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (253.47 KB, patch)
2018-04-23 20:16 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (253.30 KB, patch)
2018-04-23 20:59 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (253.28 KB, patch)
2018-04-23 23:10 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (251.56 KB, patch)
2018-04-24 08:36 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (266.98 KB, patch)
2018-04-25 10:18 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-04-20 17:15:54 PDT 
This will allow logging to be more consistent between WK1 and WK2
Comment 1 youenn fablet 2018-04-20 17:18:16 PDT 
Created attachment 338500 [details]
Patch
Comment 2 EWS Watchlist 2018-04-20 20:53:34 PDT 
Comment on attachment 338500 [details]
Patch

Attachment 338500 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7392434

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/opaque-response-preloaded.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html
Comment 3 EWS Watchlist 2018-04-20 20:53:36 PDT 
Created attachment 338516 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 4 EWS Watchlist 2018-04-20 22:21:52 PDT 
Comment on attachment 338500 [details]
Patch

Attachment 338500 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7393470

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/opaque-response-preloaded.https.html
imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html
Comment 5 EWS Watchlist 2018-04-20 22:21:53 PDT 
Created attachment 338522 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 6 youenn fablet 2018-04-23 15:04:50 PDT 
Created attachment 338604 [details]
Patch
Comment 7 youenn fablet 2018-04-23 20:16:18 PDT 
Created attachment 338633 [details]
Patch
Comment 8 youenn fablet 2018-04-23 20:59:34 PDT 
Created attachment 338635 [details]
Patch
Comment 9 youenn fablet 2018-04-23 23:10:01 PDT 
Created attachment 338639 [details]
Patch
Comment 10 youenn fablet 2018-04-24 08:36:40 PDT 
Created attachment 338652 [details]
Patch
Comment 11 Chris Dumez 2018-04-25 08:54:25 PDT 
Comment on attachment 338652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338652&action=review

> Source/WebCore/loader/CrossOriginPreflightChecker.cpp:63
> +    Frame* frame = loader.document().frame();

auto*

> Source/WebCore/loader/CrossOriginPreflightChecker.cpp:68
> +        if (frame->document())

if (auto* document = frame->document())
    document->
Comment 12 youenn fablet 2018-04-25 10:18:17 PDT 
Created attachment 338749 [details]
Patch for landing
Comment 13 WebKit Commit Bot 2018-04-25 10:58:04 PDT 
Comment on attachment 338749 [details]
Patch for landing

Clearing flags on attachment: 338749

Committed r231000: <https://trac.webkit.org/changeset/231000>
Comment 14 WebKit Commit Bot 2018-04-25 10:58:06 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2018-04-25 10:59:31 PDT 
<rdar://problem/39727000>