Bug 184847 - AX: AOM does not work with DOM Level 1 events
Summary: AX: AOM does not work with DOM Level 1 events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-20 15:47 PDT by Nan Wang
Modified: 2018-04-20 23:56 PDT (History)
14 users (show)

See Also:


Attachments
patch (17.20 KB, patch)
2018-04-20 16:05 PDT, Nan Wang
cfleizach: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Wang 2018-04-20 15:47:05 PDT
AOM does not work with DOM Level 1 events, only works with DOM Level 2.

<rdar://problem/39477642>
Comment 1 Nan Wang 2018-04-20 16:05:12 PDT
Created attachment 338481 [details]
patch
Comment 2 chris fleizach 2018-04-20 16:19:53 PDT
there's probably some other tests that would need updating. do these need to be gated by feature flag?
Comment 3 Nan Wang 2018-04-20 16:25:14 PDT
(In reply to chris fleizach from comment #2)
> there's probably some other tests that would need updating. do these need to
> be gated by feature flag?

I think these tests have covered all the accessibility event types we currently have. I'll double check with the feature flag.
Comment 4 Ryosuke Niwa 2018-04-20 16:31:44 PDT
Comment on attachment 338481 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338481&action=review

> LayoutTests/accessibility/mac/AOM-events-all.html:118
> -            debug("\nTest accessiblescrollintoview");
> +            debug("\nTest accessiblescrollintoview");            

Trailing whitespace.
Comment 5 Nan Wang 2018-04-20 23:49:28 PDT
(In reply to Ryosuke Niwa from comment #4)
> Comment on attachment 338481 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338481&action=review
> 
> > LayoutTests/accessibility/mac/AOM-events-all.html:118
> > -            debug("\nTest accessiblescrollintoview");
> > +            debug("\nTest accessiblescrollintoview");            
> 
> Trailing whitespace.

Ok will remove
Comment 6 Nan Wang 2018-04-20 23:56:31 PDT
Committed r230890: <https://trac.webkit.org/changeset/230890>