Bug 184843 – tex[Sub]Image2D slow when passing in a <canvas>, faster with ImageData

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Justin Fan]

There are some performance issues with html 2D canvas rendering involving FormatConverter::convert()'s pixel packing methods.

[Justin Fan]

<rdar://problem/34898868>

[Justin Fan]

Created attachment 338475 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 338475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338475&action=review

> Source/WebCore/platform/graphics/FormatConverter.cpp:1
> -/*
> +  /*

Ooops.

> Source/WebCore/platform/graphics/FormatConverter.cpp:1263
> +        // FIXME: [34898868] Experimental Accelerate Alpha Unmultiplicaton for this specific case; general performance improvements later.

I don't think this radar links adds anything.

[EWS Watchlist]

Comment on attachment 338475 [details]
Patch

Attachment 338475 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7389225

New failing tests:
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgb565.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba5551.html
webgl/1.0.2/conformance/textures/gl-teximage.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba4444.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgba4444.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-video-rgb565.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgb565.html
fast/canvas/webgl/tex-image-with-format-and-type.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-data.html
webgl/1.0.2/conformance/textures/tex-image-with-format-and-type.html

[EWS Watchlist]

Created attachment 338489 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 338475 [details]
Patch

Attachment 338475 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7389284

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 338501 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 338475 [details]
Patch

Attachment 338475 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7390760

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 338506 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 338475 [details]
Patch

Attachment 338475 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7391504

New failing tests:
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-array-buffer-view.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba5551.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba4444.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba5551.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba4444.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba4444.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgb565.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgba5551.html
fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgb565.html
fast/canvas/webgl/tex-image-with-format-and-type.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-rgba4444.html
webgl/1.0.2/conformance/textures/tex-image-with-format-and-type.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-rgb565.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-data-rgba5551.html
webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-image-data.html

[EWS Watchlist]

Created attachment 338512 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Justin Fan]

Created attachment 338682 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 338682 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338682&action=review

> Source/WebCore/ChangeLog:11
> +        This improves this rendering path by a factor of ~4. The rest of FormatConverter may require similar improvements.

The best thing to do here would be to file a bugzilla bug for the rest of the improvements, and reference it. Like "Filed webkit.org/b/9999 for further improvements".

> Source/WebCore/platform/graphics/FormatConverter.cpp:1265
> +        // FIXME: Experimental Accelerate Alpha Unmultiplicaton for this specific case; general performance improvements later.

Remove the comment. It only means something to you.

[Justin Fan]

Created attachment 338946 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 338946 [details]
Patch

Clearing flags on attachment: 338946

Committed r231084: <https://trac.webkit.org/changeset/231084>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.