Bug 184841 - Activate NetworkLoadChecker for media loads
Summary: Activate NetworkLoadChecker for media loads
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-20 14:49 PDT by youenn fablet
Modified: 2018-04-21 13:47 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.72 KB, patch)
2018-04-20 15:06 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (11.49 KB, patch)
2018-04-20 15:55 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (11.83 KB, patch)
2018-04-20 16:18 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (11.79 KB, patch)
2018-04-21 12:51 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-04-20 14:49:01 PDT 
Activate NetworkLoadChecker for media loads
Comment 1 youenn fablet 2018-04-20 15:06:05 PDT 
Created attachment 338465 [details]
Patch
Comment 2 youenn fablet 2018-04-20 15:55:02 PDT 
Created attachment 338474 [details]
Patch
Comment 3 youenn fablet 2018-04-20 16:18:01 PDT 
Created attachment 338484 [details]
Patch
Comment 4 Eric Carlson 2018-04-20 20:51:29 PDT 
Comment on attachment 338484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338484&action=review

> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:1274
> +    if (resourceError.isNull())
> +        return;

Nit: is it worth adding an ASSERT(resourceError.type() == ResourceError::Type::Null) when resourceError.isNull()?
Comment 5 youenn fablet 2018-04-21 12:49:37 PDT 
Comment on attachment 338484 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338484&action=review

>> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:1274
>> +        return;
> 
> Nit: is it worth adding an ASSERT(resourceError.type() == ResourceError::Type::Null) when resourceError.isNull()?

Will change to check for type() instead, thanks for the review.
Comment 6 youenn fablet 2018-04-21 12:51:08 PDT 
Created attachment 338531 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2018-04-21 13:46:50 PDT 
Comment on attachment 338531 [details]
Patch for landing

Clearing flags on attachment: 338531

Committed r230893: <https://trac.webkit.org/changeset/230893>
Comment 8 WebKit Commit Bot 2018-04-21 13:46:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-04-21 13:47:22 PDT 
<rdar://problem/39623506>