Bug 184840 – [WebGL] Add runtime flag for enabling ASTC support in WebGL

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Justin Fan]

We need a new runtime flag to enable/disable upcoming support for ASTC compression formats in WebGL for iOS.

[Radar WebKit Bug Importer]

<rdar://problem/39612467>

[Justin Fan]

Created attachment 338801 [details]
Patch

[EWS Watchlist]

Attachment 338801 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Justin Fan]

Created attachment 338806 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 338806 [details]
Patch

Rejecting attachment 338806 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 338806, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 with fuzz 3.
patching file Source/WebCore/page/RuntimeEnabledFeatures.h
Hunk #1 succeeded at 252 with fuzz 2.
Hunk #2 succeeded at 394 with fuzz 2 (offset 3 lines).
patching file Source/WebKit/Shared/WebPreferences.yaml
Hunk #1 FAILED at 1248.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Shared/WebPreferences.yaml.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Myles C. Maxfield']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/7485976

[Justin Fan]

Created attachment 339125 [details]
Patch

[Dean Jackson]

Comment on attachment 339125 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=339125&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1264
> +  humanReadableDescription: "Support for ASTC compressed texture formats"

add "in WebGL"

[WebKit Commit Bot]

Comment on attachment 339125 [details]
Patch

Rejecting attachment 339125 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 339125, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
at 1 with fuzz 3.
patching file Source/WebCore/page/RuntimeEnabledFeatures.h
Hunk #1 succeeded at 252 with fuzz 2.
Hunk #2 succeeded at 391 with fuzz 2 (offset -3 lines).
patching file Source/WebKit/Shared/WebPreferences.yaml
Hunk #1 FAILED at 1256.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Shared/WebPreferences.yaml.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/7544937

[Justin Fan]

Created attachment 339372 [details]
Patch

[Justin Fan]

Created attachment 339373 [details]
Patch

[Justin Fan]

Created attachment 339453 [details]
Patch

[Myles C. Maxfield]

You don't have to put the patch up for review again if it has already been r+'ed and you didn't change almost anything.

[WebKit Commit Bot]

Comment on attachment 339453 [details]
Patch

Clearing flags on attachment: 339453

Committed r231327: <https://trac.webkit.org/changeset/231327>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.