Bug 184839 – Web Inspector: remove some dead code in IdentifiersFactory

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

This code seems to only have been used by Chromium, and doesn't really make sense given the current architecture.

[Blaze Burg]

Created attachment 338492 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 338492 [details]
Patch

Clearing flags on attachment: 338492

Committed r230870: <https://trac.webkit.org/changeset/230870>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39615471>

[Darin Adler]

Comment on attachment 338492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338492&action=review

> Source/JavaScriptCore/inspector/IdentifiersFactory.cpp:39
> +static String addPrefixToIdentifier(const String& identifier)
> +{
> +    return makeString("0.", identifier);
> +}

If this code was at all performance critical, we should fix it to take an integer rather than a string, since makeString can convert a number to a string in place, avoiding allocating and destroying an additional string.

> Source/JavaScriptCore/inspector/IdentifiersFactory.h:35
>      static String requestId(unsigned long identifier);

The use of "unsigned long" here is peculiar. We almost never use the "long" types in WebKit code rather than the "int" types or types like "uint32_t". unless there is a special reason. What is the reason here?