Bug 184835 – Mandate H264 hardware encoder for Mac in libwebrtc

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Mandate H264 hardware encoder for Mac in libwebrtc

[youenn fablet]

Created attachment 338458 [details]
Patch

[youenn fablet]

Created attachment 338459 [details]
Patch

[Eric Carlson]

Comment on attachment 338459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338459&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm:615
> +  CFTypeRef sessionValues[] = { webrtc::isH264HardwareEncoderAllowed() ? kCFBooleanTrue : kCFBooleanFalse, webrtc::isH264HardwareEncoderAllowed() ? kCFBooleanTrue : kCFBooleanFalse, kCFBooleanTrue };

Nit: it seems slightly wasteful to call webrtc::isH264HardwareEncoderAllowed() twice here.

[youenn fablet]

Created attachment 338468 [details]
Patch for landing

[youenn fablet]

Created attachment 338469 [details]
Patch for landing

[youenn fablet]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 338459 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338459&action=review
> 
> > Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm:615
> > +  CFTypeRef sessionValues[] = { webrtc::isH264HardwareEncoderAllowed() ? kCFBooleanTrue : kCFBooleanFalse, webrtc::isH264HardwareEncoderAllowed() ? kCFBooleanTrue : kCFBooleanFalse, kCFBooleanTrue };
> 
> Nit: it seems slightly wasteful to call
> webrtc::isH264HardwareEncoderAllowed() twice here.

Thanks for the review.
I updated the patch accordingly.

[WebKit Commit Bot]

Comment on attachment 338469 [details]
Patch for landing

Clearing flags on attachment: 338469

Committed r230862: <https://trac.webkit.org/changeset/230862>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39612500>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 184855

[youenn fablet]

Created attachment 339131 [details]
Patch

[youenn fablet]

Timeouts were due to too many hw encoders allocated and returning too early to use sw encoders

[WebKit Commit Bot]

Comment on attachment 339131 [details]
Patch

Clearing flags on attachment: 339131

Committed r231167: <https://trac.webkit.org/changeset/231167>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.