The following layout test is flaky on macOS Debug accessibility/mac/async-increment-decrement-action.html Probable cause: [insert probable cause] Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fmac%2Fasync-increment-decrement-action.html
<rdar://problem/39604753>
Created attachment 338451 [details] patch fix the test
Comment on attachment 338451 [details] patch this seems a bit flaky. is there a better way?
(In reply to chris fleizach from comment #3) > Comment on attachment 338451 [details] > patch > > this seems a bit flaky. is there a better way? Not easy way since there's no callback from the actions. Or we can just test that these actions are async now and return early with the non changed result without timing out.
(In reply to Nan Wang from comment #4) > (In reply to chris fleizach from comment #3) > > Comment on attachment 338451 [details] > > patch > > > > this seems a bit flaky. is there a better way? > > Not easy way since there's no callback from the actions. Or we can just test > that these actions are async now and return early with the non changed > result without timing out. that seems reasonable
Created attachment 338452 [details] patch updated the test
Comment on attachment 338452 [details] patch looks ok, just add a comment why value isn't changing and how that verifies it's async
(In reply to chris fleizach from comment #7) > Comment on attachment 338452 [details] > patch > > looks ok, just add a comment why value isn't changing and how that verifies > it's async Ok will do after all the tests are passed
Committed r230855: <https://trac.webkit.org/changeset/230855>