only for single renderer, no pagination etc.
Created attachment 338446 [details] Patch
Comment on attachment 338446 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338446&action=review > Source/WebCore/rendering/SimpleLineLayoutFunctions.cpp:278 > +bool canUseForLineBoxTree(RenderBlockFlow& flow, const Layout& layout) > +{ > + return !layout.isPaginated() && !flow.style().preserveNewline() && flow.firstChild() && is<RenderText>(*flow.firstChild()) && flow.firstChild() == flow.lastChild(); > +} This would be more readable with multiple lines and early returns.
Comment on attachment 338446 [details] Patch Attachment 338446 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/7386391 New failing tests: fast/text/mark-matches-rendering-simple-lines.html
Created attachment 338457 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 338446 [details] Patch Attachment 338446 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7389282 Number of test failures exceeded the failure limit.
Created attachment 338491 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 338567 [details] Patch
Comment on attachment 338567 [details] Patch Attachment 338567 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7409126 Number of test failures exceeded the failure limit.
Created attachment 338568 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 338567 [details] Patch Clearing flags on attachment: 338567 Committed r230914: <https://trac.webkit.org/changeset/230914>
All reviewed patches have been landed. Closing bug.
<rdar://problem/39645850>