Bug 184831 - Pausing should clear m_waitingToEnterFullscreen
Summary: Pausing should clear m_waitingToEnterFullscreen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-20 11:20 PDT by Eric Carlson
Modified: 2018-04-30 09:55 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.27 KB, patch)
2018-04-20 11:33 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2018-04-20 11:20:48 PDT
pause() should clear m_waitingToEnterFullscreen so a subsequent play() will go into fullscreen.
Comment 1 Radar WebKit Bug Importer 2018-04-20 11:21:26 PDT
<rdar://problem/39602852>
Comment 2 Eric Carlson 2018-04-20 11:33:40 PDT
Created attachment 338443 [details]
Patch
Comment 3 WebKit Commit Bot 2018-04-20 12:01:58 PDT
Comment on attachment 338443 [details]
Patch

Clearing flags on attachment: 338443

Committed r230846: <https://trac.webkit.org/changeset/230846>
Comment 4 WebKit Commit Bot 2018-04-20 12:01:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2018-04-30 09:55:27 PDT
Comment on attachment 338443 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338443&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:3526
> +    if (m_waitingToEnterFullscreen)
> +        m_waitingToEnterFullscreen = false;

The if statement here isn’t needed. We don’t need to check a boolean to see if it’s true before setting it false.