Bug 184825 - [iOS] LayoutTest http/tests/quicklook/hide-referer-on-navigation.html is failing
Summary: [iOS] LayoutTest http/tests/quicklook/hide-referer-on-navigation.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-20 10:20 PDT by Sihui Liu
Modified: 2018-04-26 14:41 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.24 KB, patch)
2018-04-20 10:32 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2018-04-20 15:39 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2018-04-20 10:20:29 PDT 
After making policy decisions asynchronous https://bugs.webkit.org/show_bug.cgi?id=180568, this test fails.
Comment 1 Sihui Liu 2018-04-20 10:22:32 PDT 
<rdar://problem/38924997>
Comment 2 Sihui Liu 2018-04-20 10:32:39 PDT 
Created attachment 338435 [details]
Patch
Comment 3 Geoffrey Garen 2018-04-20 15:00:36 PDT 
Comment on attachment 338435 [details]
Patch

I think you've got the diagnosis right here. That's great!

Let's re-use the "runAsync" flag to specify that we don't want UIHelper.wait() to end the test early, rather than adding the "shouldWait" flag. I think the flags philosophically mean the same thing -- with the exception that re-using "runAsync" requires hide-referer-on-navigation.html to call testRunner.waitUntilDone() itself before it calls runTest().
Comment 4 Sihui Liu 2018-04-20 15:39:00 PDT 
Created attachment 338471 [details]
Patch
Comment 5 Geoffrey Garen 2018-04-26 14:14:47 PDT 
Comment on attachment 338471 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2018-04-26 14:41:44 PDT 
Comment on attachment 338471 [details]
Patch

Clearing flags on attachment: 338471

Committed r231075: <https://trac.webkit.org/changeset/231075>
Comment 7 WebKit Commit Bot 2018-04-26 14:41:46 PDT 
All reviewed patches have been landed.  Closing bug.