Bug 184812 - Update Alignment shorthands to the spec now that they are not ambiguous
Summary: Update Alignment shorthands to the spec now that they are not ambiguous
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-20 04:47 PDT by Javier Fernandez
Modified: 2018-04-20 13:09 PDT (History)
8 users (show)

See Also:


Attachments
Patch (83.42 KB, patch)
2018-04-20 04:56 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff
Patch (45.92 KB, patch)
2018-04-20 05:03 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.02 MB, application/zip)
2018-04-20 06:05 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews103 for mac-sierra (2.30 MB, application/zip)
2018-04-20 06:09 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews126 for ios-simulator-wk2 (15.09 MB, application/zip)
2018-04-20 06:31 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews115 for mac-sierra (3.07 MB, application/zip)
2018-04-20 06:45 PDT, EWS Watchlist
no flags Details
Patch (83.38 KB, patch)
2018-04-20 07:26 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff
Patch (83.40 KB, patch)
2018-04-20 11:49 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2018-04-20 04:47:47 PDT
The grammar was simplified, and as a result the ambiguity is gone now. See:

  https://github.com/w3c/csswg-drafts/issues/2276#issuecomment-378757319
Comment 1 Javier Fernandez 2018-04-20 04:56:22 PDT
Created attachment 338408 [details]
Patch
Comment 2 Javier Fernandez 2018-04-20 05:03:50 PDT
Created attachment 338409 [details]
Patch
Comment 3 EWS Watchlist 2018-04-20 06:05:53 PDT
Comment on attachment 338409 [details]
Patch

Attachment 338409 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/7382260

New failing tests:
imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-001.html
imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-002.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-001.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-002.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-001.html
imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-002.html
imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-001.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-003.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/shorthand-serialization-001.html
Comment 4 EWS Watchlist 2018-04-20 06:05:54 PDT
Created attachment 338416 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-04-20 06:09:58 PDT
Comment on attachment 338409 [details]
Patch

Attachment 338409 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/7382414

New failing tests:
imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-001.html
imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-002.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-001.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-002.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-001.html
imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-002.html
imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-001.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-003.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/shorthand-serialization-001.html
Comment 6 EWS Watchlist 2018-04-20 06:09:59 PDT
Created attachment 338417 [details]
Archive of layout-test-results from ews103 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 EWS Watchlist 2018-04-20 06:31:28 PDT
Comment on attachment 338409 [details]
Patch

Attachment 338409 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7382377

New failing tests:
imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-001.html
imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-002.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-001.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-002.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-001.html
imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-002.html
imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-001.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-003.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/shorthand-serialization-001.html
Comment 8 EWS Watchlist 2018-04-20 06:31:30 PDT
Created attachment 338418 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 9 EWS Watchlist 2018-04-20 06:45:51 PDT
Comment on attachment 338409 [details]
Patch

Attachment 338409 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/7382554

New failing tests:
imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-001.html
imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-002.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-001.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-002.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/place-items-shorthand-001.html
imported/w3c/web-platform-tests/css/css-align/content-distribution/place-content-shorthand-002.html
imported/w3c/web-platform-tests/css/css-align/self-alignment/place-self-shorthand-001.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/parse-justify-items-003.html
imported/w3c/web-platform-tests/css/css-align/default-alignment/shorthand-serialization-001.html
Comment 10 EWS Watchlist 2018-04-20 06:45:53 PDT
Created attachment 338420 [details]
Archive of layout-test-results from ews115 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 11 Javier Fernandez 2018-04-20 07:26:59 PDT
Created attachment 338424 [details]
Patch
Comment 12 Antti Koivisto 2018-04-20 07:53:21 PDT
Comment on attachment 338424 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338424&action=review

> Source/WebCore/ChangeLog:3
> +        Update shorthands to the spec now that they are not ambiguous

The title should indicate this is specifically about alignment shorthands.
Comment 13 Javier Fernandez 2018-04-20 11:49:44 PDT
Created attachment 338445 [details]
Patch
Comment 14 WebKit Commit Bot 2018-04-20 13:06:58 PDT
Comment on attachment 338445 [details]
Patch

Clearing flags on attachment: 338445

Committed r230848: <https://trac.webkit.org/changeset/230848>
Comment 15 WebKit Commit Bot 2018-04-20 13:07:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 16 Radar WebKit Bug Importer 2018-04-20 13:09:36 PDT
<rdar://problem/39606274>