Bug 184809 - [AsyncScrolling] Add generic ScrollingThread implementation
Summary: [AsyncScrolling] Add generic ScrollingThread implementation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-19 23:08 PDT by Zan Dobersek
Modified: 2018-04-22 23:49 PDT (History)
8 users (show)

See Also:

Attachments
Patch (6.37 KB, patch)
2018-04-19 23:14 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (6.23 KB, patch)
2018-04-19 23:41 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2018-04-19 23:08:22 PDT 
[AsyncScrolling] Add generic ScrollingThread implementation
Comment 1 Zan Dobersek 2018-04-19 23:14:53 PDT 
Created attachment 338398 [details]
Patch
Comment 2 EWS Watchlist 2018-04-19 23:17:02 PDT 
Attachment 338398 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:90:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:90:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/page/scrolling/generic/ScrollingThreadGeneric.cpp:48:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2018-04-19 23:41:46 PDT 
Created attachment 338399 [details]
Patch
Comment 4 EWS Watchlist 2018-04-19 23:44:41 PDT 
Attachment 338399 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:90:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingThread.cpp:90:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/page/scrolling/generic/ScrollingThreadGeneric.cpp:48:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 3 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Yusuke Suzuki 2018-04-20 01:17:13 PDT 
Comment on attachment 338399 [details]
Patch

r=me
Comment 6 Zan Dobersek 2018-04-22 23:48:40 PDT 
Comment on attachment 338399 [details]
Patch

Clearing flags on attachment: 338399

Committed r230905: <https://trac.webkit.org/changeset/230905>
Comment 7 Zan Dobersek 2018-04-22 23:48:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-04-22 23:49:18 PDT 
<rdar://problem/39637604>