RESOLVED FIXED Bug 184807
Add a test to verify load/unload/pageshow/pagehide all work with process swapping 
https://bugs.webkit.org/show_bug.cgi?id=184807
Summary Add a test to verify load/unload/pageshow/pagehide all work with process swap...
Brady Eidson
Reported 2018-04-19 21:59:14 PDT
Add a test to verify load/unload/pageshow/pagehide all work with process swapping
Attachments
Patch (8.17 KB, patch)
2018-04-19 22:01 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
patch (8.30 KB, patch)
2018-04-20 07:39 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (8.44 KB, patch)
2018-04-20 09:21 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2018-04-19 21:59:39 PDT
<rdar://problem/38773102>
Brady Eidson
Comment 2 2018-04-19 22:01:10 PDT
Created attachment 338393 [details] Patch
EWS Watchlist
Comment 3 2018-04-19 22:04:08 PDT
Attachment 338393 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:871: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:885: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:946: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:958: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 4 2018-04-20 07:39:18 PDT
Created attachment 338427 [details] patch
EWS Watchlist
Comment 5 2018-04-20 07:42:04 PDT
Attachment 338427 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:871: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:885: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:948: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:960: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 6 2018-04-20 09:03:34 PDT
Comment on attachment 338427 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=338427&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:946 > +// Disabling the page cache explicitly is (for some reason) not availabe on iOS typo: availabe Also should end with a period.
Brady Eidson
Comment 7 2018-04-20 09:21:11 PDT
Created attachment 338431 [details] Patch
EWS Watchlist
Comment 8 2018-04-20 09:22:42 PDT
Attachment 338431 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:871: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:885: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:948: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:960: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 4 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 9 2018-04-20 10:03:22 PDT
Comment on attachment 338431 [details] Patch Clearing flags on attachment: 338431 Committed r230842: <https://trac.webkit.org/changeset/230842>
WebKit Commit Bot
Comment 10 2018-04-20 10:03:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.