Bug 184807 - Add a test to verify load/unload/pageshow/pagehide all work with process swapping
Summary: Add a test to verify load/unload/pageshow/pagehide all work with process swap...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-19 21:59 PDT by Brady Eidson
Modified: 2019-02-27 11:05 PST (History)
5 users (show)

See Also:


Attachments
Patch (8.17 KB, patch)
2018-04-19 22:01 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
patch (8.30 KB, patch)
2018-04-20 07:39 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (8.44 KB, patch)
2018-04-20 09:21 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2018-04-19 21:59:14 PDT
Add a test to verify load/unload/pageshow/pagehide all work with process swapping
Comment 1 Brady Eidson 2018-04-19 21:59:39 PDT
<rdar://problem/38773102>
Comment 2 Brady Eidson 2018-04-19 22:01:10 PDT
Created attachment 338393 [details]
Patch
Comment 3 EWS Watchlist 2018-04-19 22:04:08 PDT
Attachment 338393 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:871:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:885:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:946:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:958:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Brady Eidson 2018-04-20 07:39:18 PDT
Created attachment 338427 [details]
patch
Comment 5 EWS Watchlist 2018-04-20 07:42:04 PDT
Attachment 338427 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:871:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:885:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:948:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:960:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Chris Dumez 2018-04-20 09:03:34 PDT
Comment on attachment 338427 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338427&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:946
> +// Disabling the page cache explicitly is (for some reason) not availabe on iOS

typo: availabe

Also should end with a period.
Comment 7 Brady Eidson 2018-04-20 09:21:11 PDT
Created attachment 338431 [details]
Patch
Comment 8 EWS Watchlist 2018-04-20 09:22:42 PDT
Attachment 338431 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:871:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:885:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:948:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:960:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 WebKit Commit Bot 2018-04-20 10:03:22 PDT
Comment on attachment 338431 [details]
Patch

Clearing flags on attachment: 338431

Committed r230842: <https://trac.webkit.org/changeset/230842>
Comment 10 WebKit Commit Bot 2018-04-20 10:03:24 PDT
All reviewed patches have been landed.  Closing bug.