Make back forward cache work with process swapping This introduces reattaching to a previous process.
<rdar://problem/38676604>
Created attachment 338356 [details] Patch
Attachment 338356 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:790: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:797: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 2 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
GTK bot isn't building because its VM exhausted - Not due to the patch. Will move forward as if there wasn't GTK build coverage for this one.
Created attachment 338359 [details] patch
Attachment 338359 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:790: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:797: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 2 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 338359 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=338359&action=review r=me > Source/WebKit/UIProcess/WebBackForwardList.h:77 > + Vector<BackForwardListItemState> filteredItems(Function<bool(WebBackForwardListItem&)>&&) const; filteredItems is not very consistent with itemStates above. I would suggest filteredItemStates for consistency.
Created attachment 338391 [details] Patch for landing
Attachment 338391 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:790: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] ERROR: Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:797: Multi-line string ("...") found. This lint script doesn't do well with such strings, and may give bogus warnings. They're ugly and unnecessary, and you should use concatenation instead". [readability/multiline_string] [5] Total errors found: 2 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 338391 [details] Patch for landing Clearing flags on attachment: 338391 Committed r230834: <https://trac.webkit.org/changeset/230834>