Bug 184789 - Enable Objective-C weak references
Summary: Enable Objective-C weak references
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
Keywords: InRadar
Depends on:
Blocks: 184799
  Show dependency treegraph
Reported: 2018-04-19 11:58 PDT by David Kilzer (:ddkilzer)
Modified: 2021-01-28 14:58 PST (History)
15 users (show)

See Also:

Patch v1 (20.57 KB, patch)
2018-04-19 12:08 PDT, David Kilzer (:ddkilzer)
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2018-04-19 11:58:34 PDT
Enable Objective-C weak references in the WebKit project as a baby step towards enabling ARC.

This will let the WebKit project use the 'weak' attribute with Objective-C properties prior to enabling ARC.

(Where ARC is already enabled in a couple of test projects, we don't explicitly re-enable weak references as ARC already provides them.)
Comment 1 Radar WebKit Bug Importer 2018-04-19 11:58:49 PDT
Comment 2 David Kilzer (:ddkilzer) 2018-04-19 12:08:42 PDT
Created attachment 338348 [details]
Patch v1
Comment 3 EWS Watchlist 2018-04-19 12:10:16 PDT
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 David Kilzer (:ddkilzer) 2018-04-19 15:54:14 PDT
Committed r230824: <https://trac.webkit.org/changeset/230824>