Bug 184786 - Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
Summary: Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-19 10:41 PDT by Jer Noble
Modified: 2018-04-24 09:17 PDT (History)
5 users (show)

See Also:

Attachments
Patch (14.05 KB, patch)
2018-04-20 15:15 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (22.94 KB, patch)
2018-04-20 15:34 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (23.91 KB, patch)
2018-04-23 15:35 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (23.73 KB, patch)
2018-04-23 16:02 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-04-19 10:41:52 PDT 
Don't add system framework paths to FRAMEWORK_SEARCH_PATHS
Comment 1 Jer Noble 2018-04-20 15:15:00 PDT 
Created attachment 338466 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-04-20 15:16:25 PDT 
<rdar://problem/39611002>
Comment 3 Jer Noble 2018-04-20 15:34:57 PDT 
Created attachment 338470 [details]
Patch
Comment 4 Tim Horton 2018-04-20 15:38:41 PDT 
Comment on attachment 338470 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338470&action=review

> Source/WebCore/Configurations/WebCore.xcconfig:51
> +INSTALL_PATH = $(INSTALL_PATH_$(WK_PLATFORM_NAME));

This should totally use WK_COCOA_TOUCH

> Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:44
> -FRAMEWORK_SEARCH_PATHS[sdk=macosx*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) "$(UMBRELLA_FRAMEWORKS_DIR)" $(inherited);
> +FRAMEWORK_SEARCH_PATHS[sdk=macosx*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) $(UMBRELLA_FRAMEWORKS_DIR) $(inherited);

Where’d the quotes go
Comment 5 Jer Noble 2018-04-23 15:35:55 PDT 
Created attachment 338610 [details]
Patch for landing
Comment 6 Jer Noble 2018-04-23 16:02:49 PDT 
Created attachment 338614 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2018-04-24 09:17:15 PDT 
Comment on attachment 338614 [details]
Patch for landing

Clearing flags on attachment: 338614

Committed r230958: <https://trac.webkit.org/changeset/230958>
Comment 8 WebKit Commit Bot 2018-04-24 09:17:16 PDT 
All reviewed patches have been landed.  Closing bug.