Bug 184785 – Hide Strong Password label when text field is too narrow

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Daniel Bates]

Hide Strong Password label when text field is too narrow.

[Daniel Bates]

<rdar://problem/38183939>

[Daniel Bates]

Created attachment 338340 [details]
Patch and layout tests

[Daniel Bates]

Created attachment 338343 [details]
Patch and layout tests

[EWS Watchlist]

Comment on attachment 338343 [details]
Patch and layout tests

Attachment 338343 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/7373621

New failing tests:
fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html
fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html

[EWS Watchlist]

Created attachment 338350 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4

[Daniel Bates]

(In reply to Build Bot from comment #4)
> Comment on attachment 338343 [details]
> Patch and layout tests
> 
> Attachment 338343 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/7373621
> 
> New failing tests:
> fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-
> button.html
> fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html

These failures are expected as I need to update expected results for iOS and didn't have a build around :P I will incorporate the EWS results into the patch before landing. Once landed, I will grab the updates expected results for these tests from the GTK, Apple Windows, and WinCairo bots and then land those results.

[Daniel Bates]

Comment on attachment 338343 [details]
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=338343&action=review

> Source/WebCore/html/shadow/TextControlInnerElements.cpp:83
> +    if (!is<HTMLInputElement>(element))
> +        return false;
> +    const HTMLInputElement& inputElement = downcast<HTMLInputElement>(*element);
> +    return inputElement.isAutoFilled() && inputElement.hasAutoFillStrongPasswordButton();

It is not necessary for the field to be autofilled to be a strong password field though it will be in practice. It is enough to check that the field has the strong password button. Will mark this function inline and simplify this code to the following before landing:

return is<HTMLInputElement>(element) && downcast<HTMLInputElement>(element)->hasAutoFillStrongPasswordButton();

[Daniel Bates]

Committed r230874: <https://trac.webkit.org/changeset/230874>