Bug 184782 – [Extra zoom mode] Add a mechanism to extend the height of the layout viewport in extra zoom mode

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Wenson Hsieh]

<rdar://problem/38346712>

[Wenson Hsieh]

Created attachment 338333 [details]
Patch

[Wenson Hsieh]

Created attachment 338339 [details]
Skip fast/visual-viewport/extrazoom

[Tim Horton]

Comment on attachment 338339 [details]
Skip fast/visual-viewport/extrazoom

View in context: https://bugs.webkit.org/attachment.cgi?id=338339&action=review

> Source/WebCore/page/FrameView.cpp:1542
> +    return { baseLayoutViewportSize.width(), std::min<LayoutUnit>(documentHeight, (1 + heightExpansionFactor) * layoutViewportHeight) };

We might want to think about doing this is the horizontal direction too at some point? But fixed-left/right and horizontal scrolling is not a big thing.

> LayoutTests/fast/visual-viewport/extrazoom/layout-viewport-after-scrolling-and-resizing.html:39
> +            await UIHelper.ensurePresentationUpdate();

Maybe a comment! This shouldn’t be needed except for a bug. Which you should file. And mention here.

[Wenson Hsieh]

(In reply to Tim Horton from comment #3)
> Comment on attachment 338339 [details]
> Skip fast/visual-viewport/extrazoom
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338339&action=review
> 
> > Source/WebCore/page/FrameView.cpp:1542
> > +    return { baseLayoutViewportSize.width(), std::min<LayoutUnit>(documentHeight, (1 + heightExpansionFactor) * layoutViewportHeight) };
> 
> We might want to think about doing this is the horizontal direction too at
> some point? But fixed-left/right and horizontal scrolling is not a big thing.

I considered this, but decided to extend the height only for now...let's extend the width too if we find any websites that are actually impacted by this.

> 
> > LayoutTests/fast/visual-viewport/extrazoom/layout-viewport-after-scrolling-and-resizing.html:39
> > +            await UIHelper.ensurePresentationUpdate();
> 
> Maybe a comment! This shouldn’t be needed except for a bug. Which you should
> file. And mention here.

Good call. Filed https://bugs.webkit.org/show_bug.cgi?id=184788, and I'll mention it here too with a FIXME.

[Wenson Hsieh]

Created attachment 338353 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 338353 [details]
Patch for landing

Clearing flags on attachment: 338353

Committed r230819: <https://trac.webkit.org/changeset/230819>