Bug 184782 - [Extra zoom mode] Add a mechanism to extend the height of the layout viewport in extra zoom mode
Summary: [Extra zoom mode] Add a mechanism to extend the height of the layout viewport...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-19 08:31 PDT by Wenson Hsieh
Modified: 2018-04-20 11:33 PDT (History)
7 users (show)

See Also:

Attachments
Patch (25.37 KB, patch)
2018-04-19 10:04 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Skip fast/visual-viewport/extrazoom (25.96 KB, patch)
2018-04-19 10:29 PDT, Wenson Hsieh 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (26.18 KB, patch)
2018-04-19 13:19 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-04-19 08:31:04 PDT 
<rdar://problem/38346712>
Comment 1 Wenson Hsieh 2018-04-19 10:04:35 PDT 
Created attachment 338333 [details]
Patch
Comment 2 Wenson Hsieh 2018-04-19 10:29:13 PDT 
Created attachment 338339 [details]
Skip fast/visual-viewport/extrazoom
Comment 3 Tim Horton 2018-04-19 10:55:36 PDT 
Comment on attachment 338339 [details]
Skip fast/visual-viewport/extrazoom

View in context: https://bugs.webkit.org/attachment.cgi?id=338339&action=review

> Source/WebCore/page/FrameView.cpp:1542
> +    return { baseLayoutViewportSize.width(), std::min<LayoutUnit>(documentHeight, (1 + heightExpansionFactor) * layoutViewportHeight) };

We might want to think about doing this is the horizontal direction too at some point? But fixed-left/right and horizontal scrolling is not a big thing.

> LayoutTests/fast/visual-viewport/extrazoom/layout-viewport-after-scrolling-and-resizing.html:39
> +            await UIHelper.ensurePresentationUpdate();

Maybe a comment! This shouldn’t be needed except for a bug. Which you should file. And mention here.
Comment 4 Wenson Hsieh 2018-04-19 11:03:21 PDT 
(In reply to Tim Horton from comment #3)
> Comment on attachment 338339 [details]
> Skip fast/visual-viewport/extrazoom
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=338339&action=review
> 
> > Source/WebCore/page/FrameView.cpp:1542
> > +    return { baseLayoutViewportSize.width(), std::min<LayoutUnit>(documentHeight, (1 + heightExpansionFactor) * layoutViewportHeight) };
> 
> We might want to think about doing this is the horizontal direction too at
> some point? But fixed-left/right and horizontal scrolling is not a big thing.

I considered this, but decided to extend the height only for now...let's extend the width too if we find any websites that are actually impacted by this.

> 
> > LayoutTests/fast/visual-viewport/extrazoom/layout-viewport-after-scrolling-and-resizing.html:39
> > +            await UIHelper.ensurePresentationUpdate();
> 
> Maybe a comment! This shouldn’t be needed except for a bug. Which you should
> file. And mention here.

Good call. Filed https://bugs.webkit.org/show_bug.cgi?id=184788, and I'll mention it here too with a FIXME.
Comment 5 Wenson Hsieh 2018-04-19 13:19:50 PDT 
Created attachment 338353 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2018-04-19 14:00:56 PDT 
Comment on attachment 338353 [details]
Patch for landing

Clearing flags on attachment: 338353

Committed r230819: <https://trac.webkit.org/changeset/230819>