Bug 184776 - [GTK] Two web-platform-tests failing since r230445 "sync remaining web-platform-tests to 94b33b573a069ae5170104ca581a354a35762536"
Summary: [GTK] Two web-platform-tests failing since r230445 "sync remaining web-platfo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-19 07:35 PDT by Miguel Gomez
Modified: 2022-12-28 23:54 PST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2018-04-19 07:35:56 PDT
The tests were updated in that revision and fail since then:

imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application.html [ Failure ]
with diff
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r230797%20(6339)/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-pretty-diff.html

and

imported/w3c/web-platform-tests/streams/readable-byte-streams/general.html [ Failure ]
with diff
https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r230797%20(6339)/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-pretty-diff.html
Comment 1 Ms2ger (he/him; ⌚ UTC+1/+2) 2018-04-20 00:14:42 PDT
(In reply to Miguel Gomez from comment #0)
> The tests were updated in that revision and fail since then:
> 
> imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/
> selection-not-application.html [ Failure ]
> with diff
> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/
> r230797%20(6339)/imported/w3c/web-platform-tests/html/semantics/forms/
> textfieldselection/selection-not-application-pretty-diff.html
> 

This is a similar test bug to the one that I fixed in https://github.com/w3c/web-platform-tests/pull/8567.

> and
> 
> imported/w3c/web-platform-tests/streams/readable-byte-streams/general.html [
> Failure ]
> with diff
> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/
> r230797%20(6339)/imported/w3c/web-platform-tests/streams/readable-byte-
> streams/general-pretty-diff.html

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/streams/readable-byte-streams/general-actual.txt
@@ -1,3 +1,5 @@
+
+Harness Error (TIMEOUT), message = null
 
 PASS getReader({mode: "byob"}) throws on non-bytes streams 
 PASS ReadableStream with byte source can be constructed with no errors 
@@ -16,57 +18,64 @@
 PASS ReadableStream with byte source: releaseLock() on ReadableStreamReader with pending read() must throw 
 PASS ReadableStream with byte source: Automatic pull() after start() 
 PASS ReadableStream with byte source: Automatic pull() after start() and read() 
-PASS ReadableStream with byte source: autoAllocateChunkSize 
+FAIL ReadableStream with byte source: autoAllocateChunkSize assert_equals: pull() must have been invoked twice expected 2 but got 1
 PASS ReadableStream with byte source: Mix of auto allocate and BYOB 
 PASS ReadableStream with byte source: Automatic pull() after start() and read(view) 
 PASS ReadableStream with byte source: enqueue(), getReader(), then read() 
 PASS ReadableStream with byte source: Push source that doesn't understand pull signal 
-PASS ReadableStream with byte source: read(), but pull() function is not callable 
-PASS ReadableStream with byte source: read(view), but pull() function is not callable 
+FAIL ReadableStream with byte source: pull() function is not callable assert_throws: constructor should throw function "() => new ReadableStream({
+    pull: 'foo',
+    type: 'bytes'
+  })" did not throw
 PASS ReadableStream with byte source: enqueue() with Uint16Array, getReader(), then read() 
 PASS ReadableStream with byte source: enqueue(), read(view) partially, then read() 
 PASS ReadableStream with byte source: getReader(), enqueue(), close(), then read() 
 PASS ReadableStream with byte source: enqueue(), close(), getReader(), then read() 
 PASS ReadableStream with byte source: Respond to pull() by enqueue() 
 PASS ReadableStream with byte source: Respond to pull() by enqueue() asynchronously 
-PASS ReadableStream with byte source: read(view), then respond() 
-PASS ReadableStream with byte source: read(view), then respond() with a transferred ArrayBuffer 
-PASS ReadableStream with byte source: read(view), then respond() with too big value 
-PASS ReadableStream with byte source: respond(3) to read(view) with 2 element Uint16Array enqueues the 1 byte remainder 
-PASS ReadableStream with byte source: enqueue(), getReader(), then read(view) 
-PASS ReadableStream with byte source: enqueue(), getReader(), then cancel() (mode = not BYOB) 
-PASS ReadableStream with byte source: enqueue(), getReader(), then cancel() (mode = BYOB) 
-PASS ReadableStream with byte source: getReader(), read(view), then cancel() 
-PASS ReadableStream with byte source: cancel() with partially filled pending pull() request 
-PASS ReadableStream with byte source: enqueue(), getReader(), then read(view) where view.buffer is not fully covered by view 
-PASS ReadableStream with byte source: Multiple enqueue(), getReader(), then read(view) 
-PASS ReadableStream with byte source: enqueue(), getReader(), then read(view) with a bigger view 
-PASS ReadableStream with byte source: enqueue(), getReader(), then read(view) with a smaller views 
-PASS ReadableStream with byte source: enqueue() 1 byte, getReader(), then read(view) with Uint16Array 
-PASS ReadableStream with byte source: enqueue() 3 byte, getReader(), then read(view) with 2-element Uint16Array 
-PASS ReadableStream with byte source: read(view) with Uint16Array on close()-d stream with 1 byte enqueue()-d must fail 
-PASS ReadableStream with byte source: A stream must be errored if close()-d before fulfilling read(view) with Uint16Array 
+TIMEOUT ReadableStream with byte source: Respond to multiple pull() by separate enqueue() Test timed out
+NOTRUN ReadableStream with byte source: read(view), then respond() 
+NOTRUN ReadableStream with byte source: read(view), then respond() with a transferred ArrayBuffer 
+NOTRUN ReadableStream with byte source: read(view), then respond() with too big value 
+NOTRUN ReadableStream with byte source: respond(3) to read(view) with 2 element Uint16Array enqueues the 1 byte remainder 
+NOTRUN ReadableStream with byte source: enqueue(), getReader(), then read(view) 
+NOTRUN ReadableStream with byte source: enqueue(), getReader(), then cancel() (mode = not BYOB) 
+NOTRUN ReadableStream with byte source: enqueue(), getReader(), then cancel() (mode = BYOB) 
+NOTRUN ReadableStream with byte source: getReader(), read(view), then cancel() 
+NOTRUN ReadableStream with byte source: cancel() with partially filled pending pull() request 
+NOTRUN ReadableStream with byte source: enqueue(), getReader(), then read(view) where view.buffer is not fully covered by view 
+NOTRUN ReadableStream with byte source: Multiple enqueue(), getReader(), then read(view) 
+NOTRUN ReadableStream with byte source: enqueue(), getReader(), then read(view) with a bigger view 
+NOTRUN ReadableStream with byte source: enqueue(), getReader(), then read(view) with a smaller views 
+NOTRUN ReadableStream with byte source: enqueue() 1 byte, getReader(), then read(view) with Uint16Array 
+NOTRUN ReadableStream with byte source: enqueue() 3 byte, getReader(), then read(view) with 2-element Uint16Array 
+NOTRUN ReadableStream with byte source: read(view) with Uint16Array on close()-d stream with 1 byte enqueue()-d must fail 
+NOTRUN ReadableStream with byte source: A stream must be errored if close()-d before fulfilling read(view) with Uint16Array 
 PASS ReadableStream with byte source: Throw if close()-ed more than once 
 PASS ReadableStream with byte source: Throw on enqueue() after close() 
-PASS ReadableStream with byte source: read(view), then respond() and close() in pull() 
-PASS ReadableStream with byte source: read(view) with Uint32Array, then fill it by multiple respond() calls 
-PASS ReadableStream with byte source: read() twice, then enqueue() twice 
-PASS ReadableStream with byte source: Multiple read(view), close() and respond() 
-PASS ReadableStream with byte source: Multiple read(view), big enqueue() 
-PASS ReadableStream with byte source: Multiple read(view) and multiple enqueue() 
-PASS ReadableStream with byte source: read(view) with passing undefined as view must fail 
-PASS ReadableStream with byte source: read(view) with zero-length view must fail 
-PASS ReadableStream with byte source: read(view) with passing an empty object as view must fail 
-PASS ReadableStream with byte source: Even read(view) with passing ArrayBufferView like object as view must fail 
-PASS ReadableStream with byte source: read() on an errored stream 
-PASS ReadableStream with byte source: read(), then error() 
-PASS ReadableStream with byte source: read(view) on an errored stream 
-PASS ReadableStream with byte source: read(view), then error() 
-PASS ReadableStream with byte source: Throwing in pull function must error the stream 
-PASS ReadableStream with byte source: Throwing in pull in response to read() must be ignored if the stream is errored in it 
-PASS ReadableStream with byte source: Throwing in pull in response to read(view) function must error the stream 
-PASS ReadableStream with byte source: Throwing in pull in response to read(view) must be ignored if the stream is errored in it 
-PASS ReadableStream with byte source: default reader + autoAllocateChunkSize + byobRequest interaction 
+NOTRUN ReadableStream with byte source: read(view), then respond() and close() in pull() 
+NOTRUN ReadableStream with byte source: read(view) with Uint32Array, then fill it by multiple respond() calls 
+NOTRUN ReadableStream with byte source: read() twice, then enqueue() twice 
+NOTRUN ReadableStream with byte source: Multiple read(view), close() and respond() 
+NOTRUN ReadableStream with byte source: Multiple read(view), big enqueue() 
+NOTRUN ReadableStream with byte source: Multiple read(view) and multiple enqueue() 
+NOTRUN ReadableStream with byte source: read(view) with passing undefined as view must fail 
+NOTRUN ReadableStream with byte source: read(view) with zero-length view must fail 
+NOTRUN ReadableStream with byte source: read(view) with passing an empty object as view must fail 
+NOTRUN ReadableStream with byte source: Even read(view) with passing ArrayBufferView like object as view must fail 
+NOTRUN ReadableStream with byte source: read() on an errored stream 
+NOTRUN ReadableStream with byte source: read(), then error() 
+NOTRUN ReadableStream with byte source: read(view) on an errored stream 
+NOTRUN ReadableStream with byte source: read(view), then error() 
+NOTRUN ReadableStream with byte source: Throwing in pull function must error the stream 
+NOTRUN ReadableStream with byte source: Throwing in pull in response to read() must be ignored if the stream is errored in it 
+NOTRUN ReadableStream with byte source: Throwing in pull in response to read(view) function must error the stream 
+NOTRUN ReadableStream with byte source: Throwing in pull in response to read(view) must be ignored if the stream is errored in it 
+NOTRUN calling respond() twice on the same byobRequest should throw 
+NOTRUN calling respondWithNewView() twice on the same byobRequest should throw 
+NOTRUN calling respond(0) twice on the same byobRequest should throw even when closed 
+NOTRUN pull() resolving should not make releaseLock() possible 
+NOTRUN ReadableStream with byte source: default reader + autoAllocateChunkSize + byobRequest interaction 
 PASS ReadableStreamBYOBReader can be constructed directly 
 PASS ReadableStreamBYOBReader constructor requires a ReadableStream argument 
 PASS ReadableStreamBYOBReader constructor requires an unlocked ReadableStream
Comment 2 Diego Pino 2022-12-28 23:54:21 PST
The test(s) file under this bug is no longer failing. The test(s) was removed from TestExpectation in https://commits.webkit.org/258351@main.