Bug 184762 - Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
Summary: Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering bu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-18 16:44 PDT by Jer Noble
Modified: 2018-04-20 15:14 PDT (History)
12 users (show)

See Also:

Attachments
Patch (20.29 KB, patch)
2018-04-18 16:49 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (18.09 KB, patch)
2018-04-19 10:18 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (18.31 KB, patch)
2018-04-19 11:10 PDT, Jer Noble 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-04-18 16:44:57 PDT 
Don't put build products into WK_ALTERNATE_WEBKIT_SDK_PATH for engineering builds
Comment 1 Jer Noble 2018-04-18 16:49:03 PDT 
Created attachment 338278 [details]
Patch
Comment 2 Jer Noble 2018-04-19 10:18:37 PDT 
Created attachment 338337 [details]
Patch
Comment 3 EWS Watchlist 2018-04-19 10:20:56 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 4 Radar WebKit Bug Importer 2018-04-19 10:22:03 PDT 
<rdar://problem/39568077>
Comment 5 mitz 2018-04-19 10:23:50 PDT 
Comment on attachment 338337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338337&action=review

> Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:76
> +ANGLE_INSTALL_PATH_PREFIX_Production = $(ANGLE_INSTALL_PATH_PREFIX_Production_$(WK_USE_ALTERNATE_FRAMEWORKS_DIR));

This (and the reset of them) should be keyed off DEPLOYMENT_LOCATION rather than CONFIGURATION (like the script build phase above).
Comment 6 Jer Noble 2018-04-19 11:10:14 PDT 
Created attachment 338344 [details]
Patch
Comment 7 mitz 2018-04-19 11:37:08 PDT 
Comment on attachment 338344 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338344&action=review

> Source/WebCore/PAL/Configurations/CopyPALHeaders.xcconfig:28
> +PRIVATE_HEADERS_FOLDER_PATH = $(PAL_INSTALL_PATH_PREFIX)/usr/local/include/pal;

I think you end up with a harmless extra slash there.
Comment 8 Jer Noble 2018-04-20 15:14:48 PDT 
Committed r230858: <https://trac.webkit.org/changeset/230858>