Bug 184757 - Ensure correct screen sizes
Summary: Ensure correct screen sizes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-18 14:23 PDT by Megan Gardner
Modified: 2018-04-22 14:23 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2018-04-18 14:25 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Add a layout test (2.44 KB, patch)
2018-04-20 17:40 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2018-04-18 14:23:45 PDT 
Ensure correct screen sizes
Comment 1 Megan Gardner 2018-04-18 14:25:56 PDT 
Created attachment 338262 [details]
Patch
Comment 2 Megan Gardner 2018-04-18 14:26:23 PDT 
<rdar://problem/39540423>
Comment 3 Wenson Hsieh 2018-04-18 14:27:35 PDT 
Comment on attachment 338262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338262&action=review

> Source/WebCore/ChangeLog:6
> +        Make sure that the screen sizes are actually correct.

Nit - description goes after the "Reviewed by" line.
Comment 4 Megan Gardner 2018-04-18 14:55:25 PDT 
https://trac.webkit.org/r230785
Comment 5 Wenson Hsieh 2018-04-20 17:40:40 PDT 
Reopening to attach new patch.
Comment 6 Wenson Hsieh 2018-04-20 17:40:40 PDT 
Created attachment 338502 [details]
Add a layout test
Comment 7 WebKit Commit Bot 2018-04-22 14:23:21 PDT 
Comment on attachment 338502 [details]
Add a layout test

Clearing flags on attachment: 338502

Committed r230901: <https://trac.webkit.org/changeset/230901>
Comment 8 WebKit Commit Bot 2018-04-22 14:23:23 PDT 
All reviewed patches have been landed.  Closing bug.