Bug 184756 - Rename WindowProxyController to WindowProxy
Summary: Rename WindowProxyController to WindowProxy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 184716
Blocks:
  Show dependency treegraph
 
Reported: 2018-04-18 14:14 PDT by Chris Dumez
Modified: 2018-04-19 05:47 PDT (History)
8 users (show)

See Also:


Attachments
Patch (59.45 KB, patch)
2018-04-18 16:10 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (59.69 KB, patch)
2018-04-18 16:25 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-04-18 14:14:18 PDT
Rename WindowProxyController to WindowProxy for clarity. When the IDL uses WindowProxy, the implementation should use WindowProxyController type, which is a bit confusing currently.
Comment 1 Chris Dumez 2018-04-18 16:10:10 PDT
Created attachment 338272 [details]
Patch
Comment 2 Chris Dumez 2018-04-18 16:25:43 PDT
Created attachment 338275 [details]
Patch
Comment 3 Sam Weinig 2018-04-18 20:28:26 PDT
Comment on attachment 338275 [details]
Patch

I think its a bit odd that the class is called WindowProxy and its wrapper is JSDOMWindowProxy, but I think maybe we should address that by renaming JSDOMWindowProxy at some point. r=me.
Comment 4 Chris Dumez 2018-04-18 20:35:20 PDT
(In reply to Sam Weinig from comment #3)
> Comment on attachment 338275 [details]
> Patch
> 
> I think its a bit odd that the class is called WindowProxy and its wrapper
> is JSDOMWindowProxy, but I think maybe we should address that by renaming
> JSDOMWindowProxy at some point. r=me.

Agreed, Iā€™d like to rename it to JSWindowProxy.
Comment 5 WebKit Commit Bot 2018-04-18 21:02:36 PDT
Comment on attachment 338275 [details]
Patch

Clearing flags on attachment: 338275

Committed r230794: <https://trac.webkit.org/changeset/230794>
Comment 6 WebKit Commit Bot 2018-04-18 21:02:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-04-18 21:53:33 PDT
<rdar://problem/39553714>
Comment 8 Yusuke Suzuki 2018-04-19 05:47:38 PDT
Committed r230799: <https://trac.webkit.org/changeset/230799>