RESOLVED FIXED 184754
NetworkResourceLoader should not clean itself inside didReceiveResponse 
https://bugs.webkit.org/show_bug.cgi?id=184754
Summary NetworkResourceLoader should not clean itself inside didReceiveResponse
youenn fablet
Reported 2018-04-18 13:34:43 PDT
Cleaning itself will clean NetworkLoad which is waiting for didReceiveResponse to do other stuff.
Attachments
Patch (1.74 KB, patch)
2018-04-18 13:38 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (1.73 KB, patch)
2018-04-18 13:57 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2018-04-18 13:38:14 PDT
Created attachment 338257 [details] Patch
youenn fablet
Comment 2 2018-04-18 13:57:41 PDT
Created attachment 338259 [details] Patch
youenn fablet
Comment 3 2018-04-18 13:58:27 PDT
Crash log is: Crashed Thread: 0 Dispatch queue: com.apple.main-thread Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x000000017d4ddef8 Exception Note: EXC_CORPSE_NOTIFY Termination Signal: Segmentation fault: 11 Termination Reason: Namespace SIGNAL, Code 0xb Terminating Process: exc handler [0] Application Specific Information: This process is running with libgmalloc.dylib (GuardMalloc) which may have forced the crash due to a memory access error. Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x000000010eff6ac6 WebKit::NetworkLoad::notifyDidReceiveResponse(WebCore::ResourceResponse&&, WTF::CompletionHandler<void (WebCore::PolicyAction)>&&) + 126 1 com.apple.WebKit 0x000000010efef1f6 WebKit::NetworkDataTask::didReceiveResponse(WebCore::ResourceResponse&&, WTF::CompletionHandler<void (WebCore::PolicyAction)>&&) + 326 2 com.apple.WebKit 0x000000010f01fb0d -[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:] + 328 3 com.apple.Foundation 0x000000010e83b5df __NSBLOCKOPERATION_IS_CALLING_OUT_TO_A_BLOCK__ + 7 4 com.apple.Foundation 0x000000010e83b441 -[NSBlockOperation main] + 68
youenn fablet
Comment 4 2018-04-18 14:00:46 PDT
http/tests/xmlhttprequest/access-control-basic-denied.html is crashing with guard malloc before the patch, not after.
Ryan Haddad
Comment 5 2018-04-18 14:21:50 PDT
<rdar://problem/39487184>
WebKit Commit Bot
Comment 6 2018-04-18 14:26:11 PDT
Comment on attachment 338259 [details] Patch Clearing flags on attachment: 338259 Committed r230783: <https://trac.webkit.org/changeset/230783>
WebKit Commit Bot
Comment 7 2018-04-18 14:26:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.