WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED LATER
184743
Remove the style checker rule for using release assert with security implication
https://bugs.webkit.org/show_bug.cgi?id=184743
Summary
Remove the style checker rule for using release assert with security implication
Ryosuke Niwa
Reported
2018-04-18 11:23:59 PDT
https://trac.webkit.org/changeset/223421/webkit
made it so that style check emits an error whenever ASSERT_WITH_SECURITY_IMPLICATION is used instead of RELEASE_ASSERT_WITH_SECURITY_IMPLICATION. I don't think we should have this style rule since using ASSERT_WITH_SECURITY_IMPLICATION is a valid thing to do when there is a significant perf cost. We've already had a perf regression from people mindlessly fixing this style error.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug