RESOLVED FIXED 184739
Avoid crash if ITP Debug mode is on, but ResourceLoadStatistics are not being used 
https://bugs.webkit.org/show_bug.cgi?id=184739
Summary Avoid crash if ITP Debug mode is on, but ResourceLoadStatistics are not being...
Brent Fulgham
Reported 2018-04-18 11:04:29 PDT
If a user has the ResourceLoadStatistics logic turned off, but has the ITP Debug experimental flag turned on, you can cause a crash. This is because the WebsiteDataStore for the process doesn't bother creating a ResourceLoadStatisticsStore if the statistics machinery is not running. The ITP debug flag was being blindly set without checking if the statistics store exists or not, which can cause a crash.
Attachments
Patch (2.07 KB, patch)
2018-04-18 11:07 PDT, Brent Fulgham 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2018-04-18 11:07:11 PDT
<rdar://problem/39287964>
Brent Fulgham
Comment 2 2018-04-18 11:07:44 PDT
Created attachment 338228 [details] Patch
John Wilander
Comment 3 2018-04-18 11:09:19 PDT
Looks good to me.
David Kilzer (:ddkilzer)
Comment 4 2018-04-18 11:29:01 PDT
Comment on attachment 338228 [details] Patch r=me
Brent Fulgham
Comment 5 2018-04-18 11:56:02 PDT
Committed r230771: <https://trac.webkit.org/changeset/230771>
Note You need to log in before you can comment on or make changes to this bug.