RESOLVED FIXED184736
[WebAssembly][Modules] Import globals from wasm modules 
https://bugs.webkit.org/show_bug.cgi?id=184736
Summary [WebAssembly][Modules] Import globals from wasm modules
Yusuke Suzuki
Reported 2018-04-18 08:37:12 PDT
[WebAssembly][Modules] Import globals from wasm modules
Attachments
Patch (19.93 KB, patch)
2018-04-18 08:39 PDT, Yusuke Suzuki 		jfbastien: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-04-18 08:39:58 PDT
Created attachment 338216 [details] Patch
JF Bastien
Comment 2 2018-04-18 09:06:30 PDT
Comment on attachment 338216 [details] Patch Could you test that i64 fails? Also, can you test f32 / f64, and especially that exporting a non-canonical NaN gets it canonicalized? Otherwise r=me
Yusuke Suzuki
Comment 3 2018-04-18 09:21:36 PDT
(In reply to JF Bastien from comment #2) > Comment on attachment 338216 [details] > Patch > > Could you test that i64 fails? > Also, can you test f32 / f64, and especially that exporting a non-canonical > NaN gets it canonicalized? > > Otherwise r=me OK, added.
Yusuke Suzuki
Comment 4 2018-04-18 09:33:38 PDT
Committed r230763: <https://trac.webkit.org/changeset/230763>
Radar WebKit Bug Importer
Comment 5 2018-04-18 09:34:23 PDT
<rdar://problem/39530176>
Note You need to log in before you can comment on or make changes to this bug.