Bug 184730 - REGRESSION(r230748) [GTK][ARM] no matching function for call to 'JSC::CCallHelpers::swap(JSC::ARMRegisters::FPRegisterID&, JSC::ARMRegisters::FPRegisterID&)'
Summary: REGRESSION(r230748) [GTK][ARM] no matching function for call to 'JSC::CCallHe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-18 06:32 PDT by Tomas Popela
Modified: 2018-04-26 00:12 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2018-04-25 10:57 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (51.55 KB, patch)
2018-04-25 11:14 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Popela 2018-04-18 06:32:07 PDT
/builddir/build/BUILD/webkitgtk-2.21.1/Source/JavaScriptCore/jit/CCallHelpers.h:171:13: error: no matching function for call to 'JSC::CCallHelpers::swap(JSC::ARMRegisters::FPRegisterID&, JSC::ARMRegisters::FPRegisterID&)'
             swap(source, dest);
             ^~~~
In file included from /builddir/build/BUILD/webkitgtk-2.21.1/Source/JavaScriptCore/assembler/MacroAssembler.h:51,
                 from /builddir/build/BUILD/webkitgtk-2.21.1/Source/JavaScriptCore/runtime/BasicBlockLocation.h:29,
                 from /builddir/build/BUILD/webkitgtk-2.21.1/Source/JavaScriptCore/runtime/ControlFlowProfiler.h:29,
                 from /builddir/build/BUILD/webkitgtk-2.21.1/Source/JavaScriptCore/runtime/VM.h:35,
                 from /builddir/build/BUILD/webkitgtk-2.21.1/Source/JavaScriptCore/bytecode/ExecutableToCodeBlockEdge.h:31,
                 from /builddir/build/BUILD/webkitgtk-2.21.1/Source/JavaScriptCore/runtime/FunctionExecutable.h:28,
                 from /builddir/build/BUILD/webkitgtk-2.21.1/Source/JavaScriptCore/runtime/JSFunctionInlines.h:28,
                 from /builddir/build/BUILD/webkitgtk-2.21.1/Source/JavaScriptCore/bytecode/AccessCase.h:30,
                 from /builddir/build/BUILD/webkitgtk-2.21.1/Source/JavaScriptCore/bytecode/AccessCase.cpp:27,
                 from /builddir/build/BUILD/webkitgtk-2.21.1/armv7hl-redhat-linux-gnueabi/DerivedSources/JavaScriptCore/unified-sources/UnifiedSource25.cpp:1:
/builddir/build/BUILD/webkitgtk-2.21.1/Source/JavaScriptCore/assembler/MacroAssemblerARM.h:646:10: note: candidate: 'void JSC::MacroAssemblerARM::swap(JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID, JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID)'
     void swap(RegisterID reg1, RegisterID reg2)
          ^~~~
/builddir/build/BUILD/webkitgtk-2.21.1/Source/JavaScriptCore/assembler/MacroAssemblerARM.h:646:10: note:   no known conversion for argument 1 from 'JSC::ARMRegisters::FPRegisterID' to 'JSC::AbstractMacroAssembler<JSC::ARMAssembler>::RegisterID' {aka 'JSC::ARMRegisters::RegisterID'}
Comment 1 Mark Lam 2018-04-18 07:54:25 PDT
Interesting.  My memory is hazy, but does ARM's EABI pass floating point arguments in FP registers?
Comment 2 Tomas Popela 2018-04-25 08:41:04 PDT
I could add that it's ARMv7 hardware without Thumb 2 support.
Comment 3 Yusuke Suzuki 2018-04-25 10:57:31 PDT
Created attachment 338756 [details]
Patch
Comment 4 Yusuke Suzuki 2018-04-25 10:58:28 PDT
(In reply to Mark Lam from comment #1)
> Interesting.  My memory is hazy, but does ARM's EABI pass floating point
> arguments in FP registers?

hardfp one uses this.
Comment 5 Yusuke Suzuki 2018-04-25 11:14:02 PDT
Created attachment 338760 [details]
Patch
Comment 6 Mark Lam 2018-04-25 12:12:48 PDT
Comment on attachment 338760 [details]
Patch

Nice work.  r=me
Comment 7 Yusuke Suzuki 2018-04-25 12:30:05 PDT
Thanks for your review!
Comment 8 WebKit Commit Bot 2018-04-25 12:55:16 PDT
Comment on attachment 338760 [details]
Patch

Clearing flags on attachment: 338760

Committed r231011: <https://trac.webkit.org/changeset/231011>
Comment 9 WebKit Commit Bot 2018-04-25 12:55:18 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2018-04-25 12:56:50 PDT
<rdar://problem/39731210>
Comment 11 Tomas Popela 2018-04-26 00:12:24 PDT
Thank you Yusuke for the fix!