Bug 184719 - Don't activate selection on become first responder
Summary: Don't activate selection on become first responder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-17 17:07 PDT by Megan Gardner
Modified: 2018-04-17 18:04 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.93 KB, patch)
2018-04-17 17:13 PDT, Megan Gardner 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2018-04-17 17:07:50 PDT 
Don't activate selection on become first responder
Comment 1 Megan Gardner 2018-04-17 17:13:21 PDT 
Created attachment 338164 [details]
Patch
Comment 2 Megan Gardner 2018-04-17 17:14:06 PDT 
I also talked with Morgan and he agrees that this is reasonable to do.
Comment 3 Tim Horton 2018-04-17 17:37:05 PDT 
Comment on attachment 338164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338164&action=review

> Source/WebKit/ChangeLog:9
> +        as there are not guaranteed to have selection rects immediately due to async/two process architecture. The selection

as there?

> Source/WebKit/ChangeLog:11
> +        in the past because this selection assistant was only for editable text, which would immediately set a carat, which 

caret! This is not gold.

> Source/WebKit/ChangeLog:12
> +        counted at a selection. Now that this is for non-editable text as well, activating the selection is problematic.

Counted!?
Comment 4 Radar WebKit Bug Importer 2018-04-17 18:03:46 PDT 
<rdar://problem/39512619>
Comment 5 Megan Gardner 2018-04-17 18:04:04 PDT 
https://webkit.org/b/184719
Comment 6 Megan Gardner 2018-04-17 18:04:19 PDT 
https://trac.webkit.org/r230745