Bug 18471 – Fix WebDownload.cpp compile problems for cairo/curl build

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Platform

[Daniel Zucker]

This patch replaces WebDownload.cpp with WebDownloadCFNet.cpp and WebDownloadCurl.cpp.  WebDownloadCFNet.cpp is unchanged.  WebDownloadCurl.cpp removes some function implementations and replaces them with stubs.  WebKit.vcproj is also modified to include/exclude the appropriate files from the appropriate build configurations.

[Daniel Zucker]

Created attachment 20518 [details]
divide WebDownload.cpp into WebDownloadCurl.cpp and WebDownloadCFNet.cpp

[Adam Roben (:aroben)]

Comment on attachment 20518 [details]
divide WebDownload.cpp into WebDownloadCurl.cpp and WebDownloadCFNet.cpp

It looks like this patch has a mixture of spaces and tabs in it. Please only use 4 spaces for indentation.

I think we'd ultimately be better served by moving the concept of a "download" to WebCore and having the platform differences reside at that level. Having two whole implementations of WebDownload doesn't feel like the right solution to me.

[Brent Fulgham]

This work (or a facsimile of this) is now part of WebKit.  Marking this as a duplicate and closing.

*** This bug has been marked as a duplicate of bug 23092 ***