Bug 184708 - Fix hasher tests for system with 32 bit longs
Summary: Fix hasher tests for system with 32 bit longs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-17 14:02 PDT by Jonathan Bedard
Modified: 2018-04-17 17:44 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.26 KB, patch)
2018-04-17 14:15 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (12.65 MB, application/zip)
2018-04-17 16:29 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2018-04-17 14:02:03 PDT 
The hasher API tests assume that longs will be 64 bits. The C++ standard does not make this guarantee, on some systems, longs are 32 bits.
Comment 1 Jonathan Bedard 2018-04-17 14:05:27 PDT 
<rdar://problem/39459977>
Comment 2 Jonathan Bedard 2018-04-17 14:15:50 PDT 
Created attachment 338148 [details]
Patch
Comment 3 Mark Lam 2018-04-17 14:28:02 PDT 
Comment on attachment 338148 [details]
Patch

LGTM.
Comment 4 EWS Watchlist 2018-04-17 16:28:57 PDT 
Comment on attachment 338148 [details]
Patch

Attachment 338148 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7349012

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html
Comment 5 EWS Watchlist 2018-04-17 16:29:07 PDT 
Created attachment 338158 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 Jonathan Bedard 2018-04-17 17:16:09 PDT 
Comment on attachment 338148 [details]
Patch

The tree is red on Windows EWS and this change could not be effecting those tests since we don't run API tests in EWS.
Comment 7 WebKit Commit Bot 2018-04-17 17:42:37 PDT 
Comment on attachment 338148 [details]
Patch

Clearing flags on attachment: 338148

Committed r230742: <https://trac.webkit.org/changeset/230742>
Comment 8 WebKit Commit Bot 2018-04-17 17:42:39 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2018-04-17 17:44:08 PDT 
<rdar://problem/39511972>