RESOLVED FIXED Bug 184708
Fix hasher tests for system with 32 bit longs 
https://bugs.webkit.org/show_bug.cgi?id=184708
Summary Fix hasher tests for system with 32 bit longs
Jonathan Bedard
Reported 2018-04-17 14:02:03 PDT
The hasher API tests assume that longs will be 64 bits. The C++ standard does not make this guarantee, on some systems, longs are 32 bits.
Attachments
Patch (3.26 KB, patch)
2018-04-17 14:15 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews200 for win-future (12.65 MB, application/zip)
2018-04-17 16:29 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2018-04-17 14:05:27 PDT
<rdar://problem/39459977>
Jonathan Bedard
Comment 2 2018-04-17 14:15:50 PDT
Created attachment 338148 [details] Patch
Mark Lam
Comment 3 2018-04-17 14:28:02 PDT
Comment on attachment 338148 [details] Patch LGTM.
EWS Watchlist
Comment 4 2018-04-17 16:28:57 PDT
Comment on attachment 338148 [details] Patch Attachment 338148 [details] did not pass win-ews (win): Output: http://webkit-queues.webkit.org/results/7349012 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html
EWS Watchlist
Comment 5 2018-04-17 16:29:07 PDT
Created attachment 338158 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Jonathan Bedard
Comment 6 2018-04-17 17:16:09 PDT
Comment on attachment 338148 [details] Patch The tree is red on Windows EWS and this change could not be effecting those tests since we don't run API tests in EWS.
WebKit Commit Bot
Comment 7 2018-04-17 17:42:37 PDT
Comment on attachment 338148 [details] Patch Clearing flags on attachment: 338148 Committed r230742: <https://trac.webkit.org/changeset/230742>
WebKit Commit Bot
Comment 8 2018-04-17 17:42:39 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-04-17 17:44:08 PDT
<rdar://problem/39511972>
Note You need to log in before you can comment on or make changes to this bug.