Bug 184699 – [GTK] Generate a JSC bundle on the 64 and 32 bit release bots and upload it to webkitgtk.org

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

The developers from the jsvu project <https://github.com/GoogleChromeLabs/jsvu> will like access to the JSC built products the x86_64 and x86_32 WebKitGTK+ (Linux) bots generate daily at http://build.webkit.org/waterfall?category=GTK

More details: https://lists.webkit.org/pipermail/webkit-dev/2017-December/029805.html

In order to provide this JSC bundle, the first idea was to re-use the current built products that the x86_64 bot generates for testing on the test bots.
But there is an issue with this built products, and is that they don't bundle any libraries from JHBuild or the system.

And adding this libraries would cause the size of the bundle to grow significantly, and it will not work in any case for the 32-bit bot as this one doesn't generate a built product at all currently.

So a better idea may be to generate a new bundle specifically for JSC with only the jsc binary and the libraries that links with it.

This bundle can be generated and uploaded in a new step for the GTK release build bots (x86_64 and x86_32 bit)

[Carlos Alberto Lopez Perez]

Created attachment 338131 [details]
Patch

[EWS Watchlist]

Attachment 338131 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:66:  [BuildFactory.__init__] Undefined variable 'GenerateJSCBundle'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:101:  [TestFactory.__init__] Undefined variable 'GenerateJSCBundle'  [pylint/E0602] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Alberto Lopez Perez]

(In reply to Build Bot from comment #2)
> Attachment 338131 [details] did not pass style-queue:
> 
> 
> ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:66: 
> [BuildFactory.__init__] Undefined variable 'GenerateJSCBundle' 
> [pylint/E0602] [5]
> ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:101: 
> [TestFactory.__init__] Undefined variable 'GenerateJSCBundle' 
> [pylint/E0602] [5]
> Total errors found: 2 in 6 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

BTW, this warnings are incorrect. GenerateJSCBundle() is implemented on steps.py but the tool seems confused with that. I double-checked with the script run-buildbot-test.py that the master starts fine with this config changes and does what is expected.

[Carlos Alberto Lopez Perez]

Created attachment 338136 [details]
Patch

Patch v2, minor cosmetic changes on the script

[EWS Watchlist]

Attachment 338136 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:66:  [BuildFactory.__init__] Undefined variable 'GenerateJSCBundle'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/factories.py:101:  [TestFactory.__init__] Undefined variable 'GenerateJSCBundle'  [pylint/E0602] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gustavo Noronha (kov)]

Comment on attachment 338136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338136&action=review

LGTM, and I installed the packages and deployed the file in 32bot =) sorry for the delay!

> Tools/Scripts/generate-jsc-bundle:124
> +    # Clean everthing from previous runs

everything*

> Tools/Scripts/generate-jsc-bundle:142
> +    # jsvu project preffers .zip rather than .tar.xz

prefers*

Interesting, I wasn't aware of jsvu =)

[Carlos Alberto Lopez Perez]

Committed r231230: <https://trac.webkit.org/changeset/231230>

[Radar WebKit Bug Importer]

<rdar://problem/39900292>

[Carlos Alberto Lopez Perez]

Committed r231256: <https://trac.webkit.org/changeset/231256>