Bug 184695 - getCharNumAtPosition should take DOMPointInit as argument
Summary: getCharNumAtPosition should take DOMPointInit as argument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords: InRadar
Depends on:
Blocks: 184767
  Show dependency tree / graph
 
Reported: 2018-04-17 08:27 PDT by Dirk Schulze
Modified: 2018-05-02 14:39 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.63 KB, patch)
2018-04-17 08:37 PDT, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Patch (8.05 KB, patch)
2018-04-17 08:49 PDT, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Patch for landing (8.09 KB, patch)
2018-05-02 14:13 PDT, Dirk Schulze 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2018-04-17 08:27:27 PDT 
SVG2 currently defines DOMPoint[1] as argument for getCharNumAtPosition. This is going to change to a DOMPointInit[2].

[1] https://www.w3.org/TR/SVG2/text.html#InterfaceSVGTextContentElement
[2] https://github.com/w3c/svgwg/pull/414
Comment 1 Dirk Schulze 2018-04-17 08:37:41 PDT 
Created attachment 338116 [details]
Patch
Comment 2 Dirk Schulze 2018-04-17 08:49:39 PDT 
Created attachment 338119 [details]
Patch
Comment 3 Dirk Schulze 2018-05-01 11:53:33 PDT 
PR for DOMPointInit landed.
Comment 4 Dirk Schulze 2018-05-02 14:13:52 PDT 
Created attachment 339337 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-05-02 14:38:58 PDT 
Comment on attachment 339337 [details]
Patch for landing

Clearing flags on attachment: 339337

Committed r231266: <https://trac.webkit.org/changeset/231266>
Comment 6 WebKit Commit Bot 2018-05-02 14:39:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-05-02 14:39:21 PDT 
<rdar://problem/39919509>