Bug 184687 - [GLIB] Make it possible to handle JSCClass external properties not added to the prototype
Summary: [GLIB] Make it possible to handle JSCClass external properties not added to t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2018-04-17 01:45 PDT by Carlos Garcia Campos
Modified: 2018-04-17 23:52 PDT (History)
9 users (show)

See Also:

Attachments
Patch (56.43 KB, patch)
2018-04-17 01:52 PDT, Carlos Garcia Campos 		mcatanzaro: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2018-04-17 01:45:12 PDT 
This is required to implement dynamic properties that can't be added with jsc_class_add_property() for example to implement something like imports object in seed/gjs.
Comment 1 Carlos Garcia Campos 2018-04-17 01:52:54 PDT 
Created attachment 338092 [details]
Patch
Comment 2 EWS Watchlist 2018-04-17 03:07:06 PDT 
Comment on attachment 338092 [details]
Patch

Attachment 338092 [details] did not pass jsc-ews (mac):
Output: http://webkit-queues.webkit.org/results/7341696

New failing tests:
stress/ftl-get-by-id-getter-exception-interesting-live-state.js.ftl-eager-no-cjit
Comment 3 Carlos Garcia Campos 2018-04-17 23:51:46 PDT 
Committed r230753: <https://trac.webkit.org/changeset/230753>
Comment 4 Radar WebKit Bug Importer 2018-04-17 23:52:22 PDT 
<rdar://problem/39519419>