Bug 184683 - Release assert in InjectedBundle::postSynchronousMessage
Summary: Release assert in InjectedBundle::postSynchronousMessage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-17 00:21 PDT by Ryosuke Niwa
Modified: 2018-04-17 14:54 PDT (History)
6 users (show)

See Also:

Attachments
Fixes the bug (2.26 KB, patch)
2018-04-17 00:49 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews202 for win-future (12.14 MB, application/zip)
2018-04-17 02:32 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2018-04-17 00:21:10 PDT 
We need to make InjectedBundle::postSynchronousMessage use DoNotProcessIncomingMessagesWhenWaitingForSyncReply

<rdar://problem/39393988>
Comment 1 Ryosuke Niwa 2018-04-17 00:49:52 PDT 
Created attachment 338085 [details]
Fixes the bug
Comment 2 EWS Watchlist 2018-04-17 00:51:10 PDT 
Attachment 338085 [details] did not pass style-queue:


ERROR: Source/WebKit/WebProcess/InjectedBundle/InjectedBundle.cpp:141:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EWS Watchlist 2018-04-17 02:32:29 PDT 
Comment on attachment 338085 [details]
Fixes the bug

Attachment 338085 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7341503

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
Comment 4 EWS Watchlist 2018-04-17 02:32:40 PDT 
Created attachment 338094 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 Ryosuke Niwa 2018-04-17 14:54:44 PDT 
Comment on attachment 338085 [details]
Fixes the bug

Clearing flags on attachment: 338085

Committed r230729: <https://trac.webkit.org/changeset/230729>
Comment 6 Ryosuke Niwa 2018-04-17 14:54:46 PDT 
All reviewed patches have been landed.  Closing bug.