RESOLVED FIXED184675
[iOS] Enable WKPDFView by default 
https://bugs.webkit.org/show_bug.cgi?id=184675
Summary [iOS] Enable WKPDFView by default
Andy Estes
Reported 2018-04-16 17:20:32 PDT
[iOS] Enable WKPDFView by default
Attachments
Patch (4.17 KB, patch)
2018-04-16 17:22 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2018-04-16 17:20:49 PDT
rdar://problem/27885452
Andy Estes
Comment 2 2018-04-16 17:22:56 PDT
Created attachment 338063 [details] Patch
Darin Adler
Comment 3 2018-04-16 17:54:32 PDT
Comment on attachment 338063 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=338063&action=review > Source/WTF/wtf/FeatureDefines.h:170 > +#if PLATFORM(IOS) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) && !ENABLE(MINIMAL_SIMULATOR) && __IPHONE_OS_VERSION_MIN_REQUIRED < 120000 Another way to do this would be to put this after the ENABLE_WKPDFVIEW paragraph and do it only #if !ENABLE(WKPFDVIEW). I’ll note that if someone sets both ENABLE_WKLEGACYPDFVIEW and ENABLE_WKPDFVIEW, we do allow nonsense combinations like having both enabled. Not sure what our usual style/strategy is for this. Could imagine using #error or something.
WebKit Commit Bot
Comment 4 2018-04-16 18:20:48 PDT
Comment on attachment 338063 [details] Patch Clearing flags on attachment: 338063 Committed r230694: <https://trac.webkit.org/changeset/230694>
WebKit Commit Bot
Comment 5 2018-04-16 18:20:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.