Bug 184674 - Commit order should always be returned by api.
Summary: Commit order should always be returned by api.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 183888
  Show dependency treegraph
Reported: 2018-04-16 17:08 PDT by dewei_zhu
Modified: 2018-04-17 02:44 PDT (History)
2 users (show)

See Also:

Patch (17.54 KB, patch)
2018-04-16 17:13 PDT, dewei_zhu
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dewei_zhu 2018-04-16 17:08:24 PDT
Commit order should always be returned by api.
Comment 1 dewei_zhu 2018-04-16 17:13:45 PDT
Created attachment 338061 [details]
Comment 2 Ryosuke Niwa 2018-04-17 02:44:14 PDT
Comment on attachment 338061 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=338061&action=review

> Websites/perf.webkit.org/public/api/measurement-set.php:223
> +            $order = !strlen($trimmed_order) ? NULL : intval($trimmed_order);

I think it's a little more straight forward to do: strlen($trimmed_order) ? intval($trimmed_order) : NULL.