Bug 184672 - PutStackSinkingPhase should know that KillStack means ConflictingFlush
Summary: PutStackSinkingPhase should know that KillStack means ConflictingFlush
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-16 16:10 PDT by Filip Pizlo
Modified: 2018-04-17 12:54 PDT (History)
6 users (show)

See Also:

Attachments
possible patch (6.24 KB, patch)
2018-04-16 17:16 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (9.83 KB, patch)
2018-04-16 18:54 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (8.01 KB, patch)
2018-04-17 12:37 PDT, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2018-04-16 16:10:13 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2018-04-16 17:16:55 PDT 
Created attachment 338062 [details]
possible patch
Comment 2 Filip Pizlo 2018-04-16 18:54:58 PDT 
Created attachment 338068 [details]
the patch
Comment 3 Filip Pizlo 2018-04-17 12:37:11 PDT 
Created attachment 338143 [details]
the patch

Decided to be even more conservative and change clobberize for KillStack.

This is all perf neutral so it's probably worth it for the correctness.
Comment 4 Michael Saboff 2018-04-17 12:46:42 PDT 
Comment on attachment 338143 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338143&action=review

r=me

> Source/JavaScriptCore/ChangeLog:20
> +        KillStack along one path frough the CFG. Also, the definition of DeadFlush and ConflictingFlush in the comment

Spelling *frough*
Comment 5 Filip Pizlo 2018-04-17 12:53:59 PDT 
Landed in https://trac.webkit.org/changeset/230725/webkit
Comment 6 Radar WebKit Bug Importer 2018-04-17 12:54:17 PDT 
<rdar://problem/39500467>