Bug 184669 – Add system trace points for process launch and for initializeWebProcess

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Saam Barati]

I've been using this locally, and it's helpful. We should just commit it.

[Saam Barati]

Created attachment 338045 [details]
WIP

Just dropping this here because I need to revert these files locally. I seem to have lost the full patch. I'll rewrite it in a bit.

[Saam Barati]

Created attachment 338053 [details]
patch

[Saam Barati]

I haven't tried compiling this locally, so I'll let EWS let me know if I messed it up.

[Simon Fraser (smfr)]

Comment on attachment 338053 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338053&action=review

> Source/WebKit/WebProcess/WebProcess.cpp:282
> +    TraceScope traceScope(ProcessLaunchStart, ProcessLaunchEnd);

You're using the same codes for both UI and web process sides. I think this will result in confusion; you should use different codes.

[Saam Barati]

Comment on attachment 338053 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338053&action=review

>> Source/WebKit/WebProcess/WebProcess.cpp:282
>> +    TraceScope traceScope(ProcessLaunchStart, ProcessLaunchEnd);
> 
> You're using the same codes for both UI and web process sides. I think this will result in confusion; you should use different codes.

Yeah this is a copy paste bug. It should be InitializeWebProcessStart/End

I'll fix it locally.

[Saam Barati]

Comment on attachment 338053 [details]
patch

Will just upload a new patch

[Saam Barati]

Created attachment 338055 [details]
patch

[Saam Barati]

Created attachment 338059 [details]
patch

[EWS Watchlist]

Comment on attachment 338059 [details]
patch

Attachment 338059 [details] did not pass win-ews (win):
Output: http://webkit-queues.webkit.org/results/7337531

New failing tests:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

[EWS Watchlist]

Created attachment 338067 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Saam Barati]

(In reply to Build Bot from comment #9)
> Comment on attachment 338059 [details]
> patch
> 
> Attachment 338059 [details] did not pass win-ews (win):
> Output: http://webkit-queues.webkit.org/results/7337531
> 
> New failing tests:
> http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

This is definitely not my patch.

[WebKit Commit Bot]

Comment on attachment 338059 [details]
patch

Clearing flags on attachment: 338059

Committed r230711: <https://trac.webkit.org/changeset/230711>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/39491891>