Bug 184667 - Ignore test262 test results associated with Test262 runner
Summary: Ignore test262 test results associated with Test262 runner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on: 183343
Blocks:
  Show dependency tree / graph
 
Reported: 2018-04-16 13:55 PDT by Michael Saboff
Modified: 2018-04-24 12:50 PDT (History)
3 users (show)

See Also:

Attachments
Patch (967 bytes, patch)
2018-04-18 09:13 PDT, Leo Balter 		no flags Details | Formatted Diff | Diff
Patch (968 bytes, patch)
2018-04-18 09:14 PDT, Leo Balter 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2018-04-16 13:55:50 PDT 
The test results from Test262 runner are 7MB and WebKit bugzilla doesn't like that large of test file.  This bug is to land that file separate from the main test262 runner changes.
Comment 1 Leo Balter 2018-04-18 09:13:56 PDT 
Created attachment 338219 [details]
Patch
Comment 2 Leo Balter 2018-04-18 09:14:54 PDT 
Created attachment 338220 [details]
Patch
Comment 3 Leo Balter 2018-04-18 09:18:38 PDT 
I added a small patch suggestion we just ignore the results file. I've been thinking here and I believe this file is good for consuming manually or through CI but those would need to perform a full run to collect the most accurate results anyway.

For now, I can't see a good argument to have this file merged unless you prefer otherwise.
Comment 4 Michael Saboff 2018-04-24 12:21:49 PDT 
Comment on attachment 338220 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2018-04-24 12:49:06 PDT 
Comment on attachment 338220 [details]
Patch

Clearing flags on attachment: 338220

Committed r230967: <https://trac.webkit.org/changeset/230967>
Comment 6 WebKit Commit Bot 2018-04-24 12:49:07 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-04-24 12:50:24 PDT 
<rdar://problem/39694143>