Bug 184658 - [WPE][GTK] GObject introspection annotation fixes: BackForwardList, NetworkProxySettings
Summary: [WPE][GTK] GObject introspection annotation fixes: BackForwardList, NetworkPr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Trivial
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-04-16 11:01 PDT by Dylan Simon
Modified: 2018-04-17 10:13 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.94 KB, patch)
2018-04-16 11:44 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dylan Simon 2018-04-16 11:01:20 PDT 
The following functions can return NULL but are not marked as (nullable):
webkit_back_forward_list_get_current_item
webkit_back_forward_list_get_back_item
webkit_back_forward_list_get_forward_item
webkit_back_forward_list_get_nth_item

The @ignoreHosts argument to webkit_network_proxy_settings_new should be marked as (array zero-terminated=1).
Comment 1 Michael Catanzaro 2018-04-16 11:44:31 PDT 
Created attachment 338020 [details]
Patch
Comment 2 EWS Watchlist 2018-04-16 11:45:56 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2018-04-17 10:13:06 PDT 
Comment on attachment 338020 [details]
Patch

Clearing flags on attachment: 338020

Committed r230718: <https://trac.webkit.org/changeset/230718>
Comment 4 WebKit Commit Bot 2018-04-17 10:13:08 PDT 
All reviewed patches have been landed.  Closing bug.