Bug 184657 - Clean up OTHER_LDFLAGS for WebKit processes
Summary: Clean up OTHER_LDFLAGS for WebKit processes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-16 10:28 PDT by Timothy Hatcher
Modified: 2018-04-16 20:01 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.78 KB, patch)
2018-04-16 10:33 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (1.55 KB, patch)
2018-04-16 19:22 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2018-04-16 10:28:51 PDT
Change how OTHER_LDFLAGS adds additional frameworks to match WebKit.
Comment 1 Timothy Hatcher 2018-04-16 10:33:15 PDT
Created attachment 338012 [details]
Patch
Comment 2 WebKit Commit Bot 2018-04-16 11:29:26 PDT
Comment on attachment 338012 [details]
Patch

Clearing flags on attachment: 338012

Committed r230673: <https://trac.webkit.org/changeset/230673>
Comment 3 WebKit Commit Bot 2018-04-16 11:29:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-04-16 11:30:28 PDT
<rdar://problem/39463307>
Comment 5 Saam Barati 2018-04-16 19:08:28 PDT
This broke 32-bit Mac build (i386).
Comment 7 Saam Barati 2018-04-16 19:11:37 PDT
EWS also said this patch was broken :-(
Comment 8 Timothy Hatcher 2018-04-16 19:20:07 PDT
Broke the 32-bit Mac build.
Comment 9 Timothy Hatcher 2018-04-16 19:22:28 PDT
Created attachment 338071 [details]
Patch
Comment 10 WebKit Commit Bot 2018-04-16 20:01:13 PDT
Comment on attachment 338071 [details]
Patch

Clearing flags on attachment: 338071

Committed r230698: <https://trac.webkit.org/changeset/230698>
Comment 11 WebKit Commit Bot 2018-04-16 20:01:15 PDT
All reviewed patches have been landed.  Closing bug.