Bug 184656 – Disable backward and forward navigation swipes while in fullscreen.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Jeremy Jones]

Disable backward and forward navigation swipes while in fullscreen.

[Jeremy Jones]

rdar://problem/36057535

[Jeremy Jones]

Created attachment 338015 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 338015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338015&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:334
>      BOOL _allowsBackForwardNavigationGestures;
> +    BOOL _disableBackForwardNavigationGestures;

This is really confusing. At least add a comment saying which one wins.

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.h:706
>      bool m_allowsBackForwardNavigationGestures { false };
> +    bool m_disableBackForwardNavigationGestures { false };

Same here.

[Jeremy Jones]

Comment on attachment 338015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338015&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:334
>> +    BOOL _disableBackForwardNavigationGestures;
> 
> This is really confusing. At least add a comment saying which one wins.

// Back-forward navigation requires both  _allowsBackForwardNavigationGestures and not _disableBackForwardNavigationGestures.

[Jeremy Jones]

Created attachment 338486 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 338486 [details]
Patch

Clearing flags on attachment: 338486

Committed r230873: <https://trac.webkit.org/changeset/230873>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

Comment on attachment 338486 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=338486&action=review

> Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp:119
> +    if (m_webPageProxy.fullScreenManager() && m_webPageProxy.fullScreenManager()->isFullScreen())

This seems to have broken the iOS build:
/Volumes/Data/slave/ios-simulator-11-release/build/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp:119:24: error: no member named 'fullScreenManager' in 'WebKit::WebPageProxy'
    if (m_webPageProxy.fullScreenManager() && m_webPageProxy.fullScreenManager()->isFullScreen())
        ~~~~~~~~~~~~~~ ^
/Volumes/Data/slave/ios-simulator-11-release/build/Source/WebKit/UIProcess/Cocoa/ViewGestureController.cpp:119:62: error: no member named 'fullScreenManager' in 'WebKit::WebPageProxy'
    if (m_webPageProxy.fullScreenManager() && m_webPageProxy.fullScreenManager()->isFullScreen())
                                              ~~~~~~~~~~~~~~ ^
2 errors generated.

https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20%28Build%29/builds/5257/steps/compile-webkit/logs/stdio

[WebKit Commit Bot]

Re-opened since this is blocked by bug 184857

[Jeremy Jones]

Created attachment 338526 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 338526 [details]
Patch for landing

Clearing flags on attachment: 338526

Committed r230896: <https://trac.webkit.org/changeset/230896>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.