Bug 184652 - [GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor
Summary: [GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default sel...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-16 08:32 PDT by Thibault Saunier
Modified: 2018-04-16 11:34 PDT (History)
4 users (show)

See Also:

Attachments
[GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor (3.18 KB, patch)
2018-04-16 08:32 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
[GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor (3.20 KB, patch)
2018-04-16 08:36 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
>> Source/WebCore/ChangeLog:9 (3.21 KB, patch)
2018-04-16 09:40 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-03 for mac-sierra (2.22 MB, application/zip)
2018-04-16 10:47 PDT, WebKit Commit Bot 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-04-16 08:32:08 PDT 
See commit message.
Comment 1 Thibault Saunier 2018-04-16 08:32:29 PDT 
Created attachment 338004 [details]
[GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor

In the constructor we should mark selected stream based on the default values from GstStream,
the if the user changes those will be updated as required
Comment 2 Thibault Saunier 2018-04-16 08:36:22 PDT 
Created attachment 338005 [details]
[GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor

In the constructor we should mark selected stream based on the default values from GstStream,
the if the user changes those will be updated as required
Comment 3 Philippe Normand 2018-04-16 08:42:29 PDT 
Comment on attachment 338005 [details]
[GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor

View in context: https://bugs.webkit.org/attachment.cgi?id=338005&action=review

LGTM  otherwise

> Source/WebCore/ChangeLog:9
> +        the if the user changes those will be updated as required

spurious "the" :)
Comment 4 Thibault Saunier 2018-04-16 09:40:27 PDT 
Created attachment 338007 [details]
>> Source/WebCore/ChangeLog:9

>> +        the if the user changes those will be updated as required
>
> spurious "the" :)

Fixed.
Comment 5 WebKit Commit Bot 2018-04-16 10:47:53 PDT 
Comment on attachment 338007 [details]
>> Source/WebCore/ChangeLog:9

Rejecting attachment 338007 [details] from commit-queue.

New failing tests:
animations/needs-layout.html
Full output: http://webkit-queues.webkit.org/results/7332371
Comment 6 WebKit Commit Bot 2018-04-16 10:47:54 PDT 
Created attachment 338013 [details]
Archive of layout-test-results from webkit-cq-03 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-03  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 7 Thibault Saunier 2018-04-16 10:52:55 PDT 
(In reply to WebKit Commit Bot from comment #6)
> Created attachment 338013 [details]
> Archive of layout-test-results from webkit-cq-03 for mac-sierra
> 
> The attached test failures were seen while running run-webkit-tests on the
> commit-queue.
> Bot: webkit-cq-03  Port: mac-sierra  Platform: Mac OS X 10.12.6


I kind of have doubts that it is related ;)
Comment 8 Philippe Normand 2018-04-16 11:05:56 PDT 
Comment on attachment 338007 [details]
>> Source/WebCore/ChangeLog:9

Looks like a false positive indeed. Let's try again :)
Comment 9 WebKit Commit Bot 2018-04-16 11:33:19 PDT 
Comment on attachment 338007 [details]
>> Source/WebCore/ChangeLog:9

Clearing flags on attachment: 338007

Committed r230674: <https://trac.webkit.org/changeset/230674>
Comment 10 WebKit Commit Bot 2018-04-16 11:33:21 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2018-04-16 11:34:31 PDT 
<rdar://problem/39463474>