RESOLVED FIXED184652
[GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor 
https://bugs.webkit.org/show_bug.cgi?id=184652
Summary [GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default sel...
Thibault Saunier
Reported 2018-04-16 08:32:08 PDT
See commit message.
Attachments
[GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor (3.18 KB, patch)
2018-04-16 08:32 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
[GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor (3.20 KB, patch)
2018-04-16 08:36 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
>> Source/WebCore/ChangeLog:9 (3.21 KB, patch)
2018-04-16 09:40 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-cq-03 for mac-sierra (2.22 MB, application/zip)
2018-04-16 10:47 PDT, WebKit Commit Bot 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-04-16 08:32:29 PDT
Created attachment 338004 [details] [GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor In the constructor we should mark selected stream based on the default values from GstStream, the if the user changes those will be updated as required
Thibault Saunier
Comment 2 2018-04-16 08:36:22 PDT
Created attachment 338005 [details] [GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor In the constructor we should mark selected stream based on the default values from GstStream, the if the user changes those will be updated as required
Philippe Normand
Comment 3 2018-04-16 08:42:29 PDT
Comment on attachment 338005 [details] [GStreamer] Set *TrackPrivateGStreamer::active based on GstStream default select in constructor View in context: https://bugs.webkit.org/attachment.cgi?id=338005&action=review LGTM otherwise > Source/WebCore/ChangeLog:9 > + the if the user changes those will be updated as required spurious "the" :)
Thibault Saunier
Comment 4 2018-04-16 09:40:27 PDT
Created attachment 338007 [details] >> Source/WebCore/ChangeLog:9 >> + the if the user changes those will be updated as required > > spurious "the" :) Fixed.
WebKit Commit Bot
Comment 5 2018-04-16 10:47:53 PDT
Comment on attachment 338007 [details] >> Source/WebCore/ChangeLog:9 Rejecting attachment 338007 [details] from commit-queue. New failing tests: animations/needs-layout.html Full output: http://webkit-queues.webkit.org/results/7332371
WebKit Commit Bot
Comment 6 2018-04-16 10:47:54 PDT
Created attachment 338013 [details] Archive of layout-test-results from webkit-cq-03 for mac-sierra The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-03 Port: mac-sierra Platform: Mac OS X 10.12.6
Thibault Saunier
Comment 7 2018-04-16 10:52:55 PDT
(In reply to WebKit Commit Bot from comment #6) > Created attachment 338013 [details] > Archive of layout-test-results from webkit-cq-03 for mac-sierra > > The attached test failures were seen while running run-webkit-tests on the > commit-queue. > Bot: webkit-cq-03 Port: mac-sierra Platform: Mac OS X 10.12.6 I kind of have doubts that it is related ;)
Philippe Normand
Comment 8 2018-04-16 11:05:56 PDT
Comment on attachment 338007 [details] >> Source/WebCore/ChangeLog:9 Looks like a false positive indeed. Let's try again :)
WebKit Commit Bot
Comment 9 2018-04-16 11:33:19 PDT
Comment on attachment 338007 [details] >> Source/WebCore/ChangeLog:9 Clearing flags on attachment: 338007 Committed r230674: <https://trac.webkit.org/changeset/230674>
WebKit Commit Bot
Comment 10 2018-04-16 11:33:21 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2018-04-16 11:34:31 PDT
<rdar://problem/39463474>
Note You need to log in before you can comment on or make changes to this bug.