Bug 184651 - [GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible
Summary: [GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no cli...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-04-16 08:10 PDT by Thibault Saunier
Modified: 2018-04-16 09:03 PDT (History)
5 users (show)

See Also:

Attachments
[GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible (3.12 KB, patch)
2018-04-16 08:10 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
[GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible (3.15 KB, patch)
2018-04-16 08:11 PDT, Thibault Saunier 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2018-04-16 08:10:22 PDT 
See commit message.
Comment 1 Thibault Saunier 2018-04-16 08:10:31 PDT 
Created attachment 338001 [details]
[GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible

We can't notify the client if none is connected, but still we need to fill our metadatas from
the provided GstTagList, especially in the case of playbin3 where the client is not set yet
at construct time but the metadata might already be preset (and won't be updated later on).
Comment 2 Thibault Saunier 2018-04-16 08:11:11 PDT 
Created attachment 338002 [details]
[GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible

We can't notify the client if none is connected, but still we need to fill our metadatas from
the provided GstTagList, especially in the case of playbin3 where the client is not set yet
at construct time but the metadata might already be preset (and won't be updated later on).
Comment 3 WebKit Commit Bot 2018-04-16 09:02:02 PDT 
Comment on attachment 338002 [details]
[GStreamer] Set TrackPrivateBaseGStreamer metadata information even if no client is avalaible

Clearing flags on attachment: 338002

Committed r230669: <https://trac.webkit.org/changeset/230669>
Comment 4 WebKit Commit Bot 2018-04-16 09:02:03 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-04-16 09:03:36 PDT 
<rdar://problem/39457984>